linux-kernel - Re: [PATCH for-next v2 03/10] iio: accel: fxls8962af: convert to EXPORT_NS_GPL_RUNTIME_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b67c7c31-9d20-4e62-adf6-0ab0c678bed2@opensource.cirrus.com>
Date:   Mon, 18 Sep 2023 10:40:49 +0100
From:   Richard Fitzgerald <rf@...nsource.cirrus.com>
To:     Raag Jadav <raag.jadav@...el.com>, <rafael@...nel.org>,
        <len.brown@...el.com>, <pavel@....cz>,
        <Jonathan.Cameron@...wei.com>, <paul@...pouillou.net>,
        <andriy.shevchenko@...ux.intel.com>, <lars@...afoo.de>,
        <rmfrfs@...il.com>, <jean-baptiste.maneyrol@....com>,
        <lee@...nel.org>, <laurentiu.palcu@....nxp.com>,
        <l.stach@...gutronix.de>, <james.schulman@...rus.com>,
        <david.rhodes@...rus.com>
CC:     <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-iio@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <patches@...nsource.cirrus.com>,
        <mallikarjunappa.sangannavar@...el.com>, <bala.senthil@...el.com>
Subject: Re: [PATCH for-next v2 03/10] iio: accel: fxls8962af: convert to
 EXPORT_NS_GPL_RUNTIME_PM_OPS()

On 18/9/23 09:09, Raag Jadav wrote:
> With original macro being renamed to EXPORT_NS_GPL_RUNTIME_PM_OPS(),
> use the new macro.
> 
> Signed-off-by: Raag Jadav <raag.jadav@...el.com>
> ---
>   drivers/iio/accel/fxls8962af-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index be8a15cb945f..69e73c54047e 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -1282,7 +1282,7 @@ static int fxls8962af_resume(struct device *dev)
>   	return 0;
>   }
>   
> -EXPORT_NS_GPL_DEV_PM_OPS(fxls8962af_pm_ops, IIO_FXLS8962AF) = {
> +EXPORT_NS_GPL_RUNTIME_PM_OPS(fxls8962af_pm_ops, IIO_FXLS8962AF) = {
>   	SYSTEM_SLEEP_PM_OPS(fxls8962af_suspend, fxls8962af_resume)
>   	RUNTIME_PM_OPS(fxls8962af_runtime_suspend, fxls8962af_runtime_resume, NULL)
>   };
This change doesn't make sense. It changes the struct definition to use
a EXPORT_*_RUNTIME_PM_OPS() macro, which leads me to expect this is
exporting runtime pm ops. But then the struct has both SYSTEM and
RUNTIME functions.

Maybe the underlying implementations of the macros result in "doing the
right thing", but the source reads like it must be a mistake.