linux-kernel - Re: [PATCH] mm: add statistics for PUD level pagetable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZQnZIkOfY0btsd8A@unknowna0e70b2ca394.attlocal.net>
Date:   Tue, 19 Sep 2023 10:23:46 -0700
From:   Vishal Moola <vishal.moola@...il.com>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc:     akpm@...ux-foundation.org, will@...nel.org,
        aneesh.kumar@...ux.ibm.com, npiggin@...il.com,
        peterz@...radead.org, catalin.marinas@....com,
        chenhuacai@...nel.org, tsbogend@...ha.franken.de,
        dave.hansen@...ux.intel.com, luto@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, arnd@...db.de, willy@...radead.org,
        linux-arch@...r.kernel.org, linux-mm@...ck.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        loongarch@...ts.linux.dev, linux-mips@...r.kernel.org
Subject: Re: [PATCH] mm: add statistics for PUD level pagetable

On Mon, Sep 18, 2023 at 02:31:42PM +0800, Baolin Wang wrote:
> Recently, we found that cross-die access to pagetable pages on ARM64
> machines can cause performance fluctuations in our business. Currently,
> there are no PMU events available to track this situation on our ARM64
> machines, so an accurate pagetable accounting can help to analyze this
> issue, but now the PUD level pagetable accounting is missed.
> 
> So introducing pagetable_pud_ctor/dtor() to help to get an accurate
> PUD pagetable accounting, as well as converting the architectures with
> using generic PUD pagatable allocation to add corresponding PUD pagetable
> accounting. Moreover this patch will also mark the PUD level pagetable
> with PG_table flag, which will help to do sanity validation in unpoison_memory().
> 
> On my testing machine, I can see more pagetables statistics after the patch
> with page-types tool:
> 
> Before patch:
>         flags           page-count      MB  symbolic-flags                     long-symbolic-flags
> 0x0000000004000000           27326      106  __________________________g_________________       pgtable
> After patch:
> 0x0000000004000000           27541      107  __________________________g_________________       pgtable
> 
> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

Acked-by: Vishal Moola (Oracle) <vishal.moola@...il.com>