linux-kernel - Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Sep 2023 10:24:50 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Douglas Gilbert <dgilbert@...erlog.com>
Subject: Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C

On 9/19/23 10:15, Thomas Weißschuh wrote:
> On 2023-09-18 12:05:19-0700, Guenter Roeck wrote:
>> On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Weißschuh wrote:
>>> The KM002C is similar to the KM003C and seems to use the same
>>> protocol and firmware.
>>>
>>> Reported-by: Douglas Gilbert <dgilbert@...erlog.com>
>>> Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d80d64@interlog.com/
>>> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
>>> ---
>>>
>>> This patch is based on hwmon-next,
>>> commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers").
>>>
>>> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
>>
>> Applied, but please be more careful with your comments and Signed-off-by:
>> tags. There should only be one '---', and one signature.
> 
> Thanks,
> 
> the duplicate Signed-off-by is indeed an oversight which I'll
> try to avoid in the future.
> 
> As for the '---':
> 
> Two of them are generated by the 'b4' tool and I added one manually with
> the hwmon-next information.
> For other subsystems this wasn't an issue so far.
> 
> Are these duplicate sections a problem for your personal tooling or is
> it affecting something more widespread?
> 

I don't know. All I know is that checkpatch complained about the double signature,
which causes my scripts to fail. I don't know what "git am" does if it encounters
a double "---" because my scripts bailed out due to the double signature.

Guenter