linux-kernel - Re: [PATCH v3 1/3] drivers: rng: meson: add support for S4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Sep 2023 12:55:33 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Alexey Romanov <avromanov@...utedevices.com>
Cc:     narmstrong@...libre.com, neil.armstrong@...aro.org,
        olivia@...enic.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        conor@...nel.org, khilman@...libre.com, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com, f.fainelli@...il.com,
        hkallweit1@...il.com, lists@...ser.cx,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-crypto@...r.kernel.org,
        kernel@...rdevices.ru, Alexey Romanov <avromanov@...rdevices.ru>
Subject: Re: [PATCH v3 1/3] drivers: rng: meson: add support for S4

On Mon, Sep 11, 2023 at 01:11:27PM +0300, Alexey Romanov wrote:
>
> +struct meson_rng_priv {
> +	int (*read)(struct hwrng *rng, void *buf, size_t max, bool wait);
> +};
>  
>  struct meson_rng_data {
>  	void __iomem *base;
>  	struct hwrng rng;
> +	struct device *dev;
> +	const struct meson_rng_priv *priv;
>  };

Is data->priv really necessary? It doesn't seem to be used anywhere
after the probe.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt