[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230922081514.p7patdvkp4mujk6k@cab-wsm-0029881.sigma.sbrf.ru>
Date: Fri, 22 Sep 2023 08:15:27 +0000
From: Alexey Romanov <avromanov@...utedevices.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: Alexey Romanov <avromanov@...utedevices.com>,
"narmstrong@...libre.com" <narmstrong@...libre.com>,
"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
"olivia@...enic.com" <olivia@...enic.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"conor@...nel.org" <conor@...nel.org>,
"khilman@...libre.com" <khilman@...libre.com>,
"jbrunet@...libre.com" <jbrunet@...libre.com>,
"martin.blumenstingl@...glemail.com"
<martin.blumenstingl@...glemail.com>,
"f.fainelli@...il.com" <f.fainelli@...il.com>,
"hkallweit1@...il.com" <hkallweit1@...il.com>,
"lists@...ser.cx" <lists@...ser.cx>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-amlogic@...ts.infradead.org"
<linux-amlogic@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
kernel <kernel@...rdevices.ru>
Subject: Re: [PATCH v3 1/3] drivers: rng: meson: add support for S4
Hi Herbert,
On Wed, Sep 20, 2023 at 12:55:33PM +0800, Herbert Xu wrote:
> On Mon, Sep 11, 2023 at 01:11:27PM +0300, Alexey Romanov wrote:
> >
> > +struct meson_rng_priv {
> > + int (*read)(struct hwrng *rng, void *buf, size_t max, bool wait);
> > +};
> >
> > struct meson_rng_data {
> > void __iomem *base;
> > struct hwrng rng;
> > + struct device *dev;
> > + const struct meson_rng_priv *priv;
> > };
>
> Is data->priv really necessary? It doesn't seem to be used anywhere
> after the probe.
>
Are you suggesting remove meson_rng_priv and putting a pointer to read
function in meson_rng_data?
> Thanks,
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
Thank you,
Alexey
Powered by blists - more mailing lists