linux-kernel - Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbf09ddd-910b-4c1f-8dbe-8d1bcb7183d0@quicinc.com>
Date:   Wed, 20 Sep 2023 15:04:11 +0800
From:   Tengfei Fan <quic_tengfan@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <andersson@...nel.org>, <agross@...nel.org>,
        <konrad.dybcio@...aro.org>, <linus.walleij@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_tsoni@...cinc.com>, <quic_shashim@...cinc.com>,
        <quic_kaushalk@...cinc.com>, <quic_tdas@...cinc.com>,
        <quic_tingweiz@...cinc.com>, <quic_aiquny@...cinc.com>,
        <quic_ajipan@...cinc.com>, <kernel@...cinc.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl



在 9/20/2023 2:58 PM, Krzysztof Kozlowski 写道:
> On 20/09/2023 08:47, Tengfei Fan wrote:
>> Add device tree binding Documentation details for Qualcomm SM4450
>> TLMM device.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
> 
> 
> 
>> +    properties:
>> +      pins:
>> +        description:
>> +          List of gpio pins affected by the properties specified in this
>> +          subnode.
>> +        items:
>> +          oneOf:
>> +            - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-5])$"
> 
> Your driver and gpio-ranges in example tell you have 136 GPIOs, not 126.
> It's v3 but still counting GPIOs is incorrect :/
> 
> Best regards,
> Krzysztof
> 
Hi Krzysztof,
my fault, misunderstand to other platform's setting when reference, will 
update.

-- 
Thx and BRs,
Tengfei Fan