linux-kernel - Re: [PATCH v3 07/11] gpiolib: replace find_chip_by_name() with gpio_device_find_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Sep 2023 11:01:23 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v3 07/11] gpiolib: replace find_chip_by_name() with gpio_device_find_by_label()

On Mon, Sep 18, 2023 at 10:03 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> On Mon, Sep 18, 2023 at 9:23 AM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:

> > >       for (p = &table->table[0]; p->key; p++) {
> > > +             struct gpio_device *gdev __free(gpio_device_put) = NULL;
> >
> > > +             gdev = gpio_device_find_by_label(p->key);
> > > +             if (!gdev) {
> >
> > I haven't got the fix for gpio-sim, shouldn't we have the same here, i.e.
> > definition being done together with the assignment when __free() is in use?
>
> It should but I only got yelled at by Linus under the gpio-sim patch
> after I sent this one.

That happens, it's all new.
I guess ideally we should patch checkpatch to just moan about
this, I wonder how hard that could be (I've only patched it once in
my life...)

Yours,
Linus Walleij