linux-kernel - Re: [PATCH v3 04/13] firmware: arm_scmi: Align perf ops to use domain-id as in-parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpoma56EGs=gTTQGyQ5jw8f1bZvd2tJYZjYTTnkAf4A58tA@mail.gmail.com>
Date:   Thu, 21 Sep 2023 16:29:15 +0200
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Sudeep Holla <sudeep.holla@....com>,
        Cristian Marussi <cristian.marussi@....com>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>,
        Nikunj Kela <nkela@...cinc.com>,
        Prasad Sodagudi <psodagud@...cinc.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 04/13] firmware: arm_scmi: Align perf ops to use
 domain-id as in-parameter

On Fri, 25 Aug 2023 at 13:27, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> Most scmi_perf_proto_ops are already using an "u32 domain" as an
> in-parameter to indicate what performance domain we shall operate upon.
> However, some of the ops are using a "struct device *dev", which means that
> an additional OF parsing is needed each time the perf ops gets called, to
> find the corresponding domain-id.
>
> To avoid the above, but also to make the code more consistent, let's
> replace the in-parameter "struct device *dev" with an "u32 domain". Note
> that, this requires us to make some corresponding changes to the scmi
> cpufreq driver, so let's do that too.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> ---
>
> Changes in v3:
>         - Re-based.
>
> ---
>  drivers/cpufreq/scmi-cpufreq.c   | 14 +++++++++-----

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>