linux-kernel - Re: [PATCH 4/4] sh: machvec: remove custom ioport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXFSvyTGvYrc2af_Bba9hHNQ-taufOMXRPrKJGNiCP8mw@mail.gmail.com>
Date:   Thu, 21 Sep 2023 10:52:29 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Cc:     Arnd Bergmann <arnd@...db.de>, Arnd Bergmann <arnd@...nel.org>,
        linux-sh@...r.kernel.org, Rich Felker <dalias@...c.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map()

Hi Adrian,

On Thu, Sep 21, 2023 at 9:45 AM John Paul Adrian Glaubitz
<glaubitz@...sik.fu-berlin.de> wrote:
> On Fri, 2023-09-15 at 17:49 +0200, Arnd Bergmann wrote:
> > On Fri, Sep 15, 2023, at 17:41, Geert Uytterhoeven wrote:
> > > On Wed, Sep 13, 2023 at 4:30 PM Arnd Bergmann <arnd@...db.de> wrote:
> > > > On Wed, Sep 13, 2023, at 16:13, Geert Uytterhoeven wrote:
> > > >
> > > > Right, it looks like the GENERIC_IOMAP part if gone from that
> > > > series, and I also see that the PCI host bridge does not actually
> > >
> > > No, 02/30 still enables it.
> >
> > Ok.
> >
> > > > map the port I/O window. That's usually fine because very few
> > > > drivers actually need it, and it also means that there should be
> > > > no need for GENERIC_IOMAP or the simpler alternative.
> > > >
> > > > The first version probably only did it accidentally, which is a
> > > > common mistake, and I think the ones for hexagon, m68k, and
> > > > mips can probably be removed as well with some simplifiations.
> > >
> > > When not selecting GENERIC_IOMAP in v2, the build fails with:
> > >
> > > sh4-linux-gnu-ld: lib/devres.o: in function `pcim_iomap_release':
> > > devres.c:(.text+0x234): undefined reference to `pci_iounmap'
> >
> > Odd, that one is provided based on CONFIG_GENERIC_PCI_IOMAP
> > and should be provided by common code, despite the similar
> > naming this is unrelated to CONFIG_GENERIC_IOMAP.
>
> So, what would be the suggestion now to move forward? Shall I include this
> series for 6.7 or better wait until after Yoshinori's series to convert
> to device tree has been merged?

I think including Arnd's cleanups (that is, his v2) in v6.7 is fine.
Sato-san's series needs more work, and is easy to fix for Arnd's cleanup
(just provide sh_io_port_base unconditionally).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds