linux-kernel - Re: [PATCH 7/7] cxl/trace: Enclose a multiple statements macro in a do while loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de20c603-6521-1ab7-3bab-67e6a278bd1e@intel.com>
Date:   Thu, 21 Sep 2023 15:58:26 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Jeongtae Park <jtp.park@...sung.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ben Widawsky <bwidawsk@...nel.org>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Fan Ni <fan.ni@...sung.com>, <linux-cxl@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kyungsan Kim <ks0204.kim@...sung.com>,
        "Wonjae Lee" <wj28.lee@...sung.com>,
        Hojin Nam <hj96.nam@...sung.com>,
        Junhyeok Im <junhyeok.im@...sung.com>,
        Jehoon Park <jehoon.park@...sung.com>,
        "Jeongtae Park" <jeongtae.park@...il.com>
Subject: Re: [PATCH 7/7] cxl/trace: Enclose a multiple statements macro in a
 do while loop



On 9/20/23 19:51, Jeongtae Park wrote:
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: Jeongtae Park <jtp.park@...sung.com>

I think that goes against typical traceevent macros layout. I would ignore checkpatch warnings on traceevent stuff. 


> ---
>  drivers/cxl/core/trace.h | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h
> index 7aee7fb008a5..e2338773dcd6 100644
> --- a/drivers/cxl/core/trace.h
> +++ b/drivers/cxl/core/trace.h
> @@ -199,17 +199,19 @@ TRACE_EVENT(cxl_overflow,
>  	__field(u8, hdr_maint_op_class)
>  
>  #define CXL_EVT_TP_fast_assign(cxlmd, l, hdr)					\
> -	__assign_str(memdev, dev_name(&(cxlmd)->dev));				\
> -	__assign_str(host, dev_name((cxlmd)->dev.parent));			\
> -	__entry->log = (l);							\
> -	__entry->serial = (cxlmd)->cxlds->serial;				\
> -	memcpy(&__entry->hdr_uuid, &(hdr).id, sizeof(uuid_t));			\
> -	__entry->hdr_length = (hdr).length;					\
> -	__entry->hdr_flags = get_unaligned_le24((hdr).flags);			\
> -	__entry->hdr_handle = le16_to_cpu((hdr).handle);			\
> -	__entry->hdr_related_handle = le16_to_cpu((hdr).related_handle);	\
> -	__entry->hdr_timestamp = le64_to_cpu((hdr).timestamp);			\
> -	__entry->hdr_maint_op_class = (hdr).maint_op_class
> +	do {									\
> +	    __assign_str(memdev, dev_name(&(cxlmd)->dev));			\
> +	    __assign_str(host, dev_name((cxlmd)->dev.parent));			\
> +	    __entry->log = (l);							\
> +	    __entry->serial = (cxlmd)->cxlds->serial;				\
> +	    memcpy(&__entry->hdr_uuid, &(hdr).id, sizeof(uuid_t));		\
> +	    __entry->hdr_length = (hdr).length;					\
> +	    __entry->hdr_flags = get_unaligned_le24((hdr).flags);		\
> +	    __entry->hdr_handle = le16_to_cpu((hdr).handle);			\
> +	    __entry->hdr_related_handle = le16_to_cpu((hdr).related_handle);	\
> +	    __entry->hdr_timestamp = le64_to_cpu((hdr).timestamp);		\
> +	    __entry->hdr_maint_op_class = (hdr).maint_op_class;			\
> +	} while (0)
>  
>  #define CXL_EVT_TP_printk(fmt, ...) \
>  	TP_printk("memdev=%s host=%s serial=%lld log=%s : time=%llu uuid=%pUb "	\