linux-kernel - Re: [PATCH 6/7] cxl/memdev: Fix whitespace error/warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQ1dIr//9aYNktzI@jtpark-7920>
Date:   Fri, 22 Sep 2023 18:23:46 +0900
From:   Jeongtae Park <jtp.park@...sung.com>
To:     Dave Jiang <dave.jiang@...el.com>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ben Widawsky <bwidawsk@...nel.org>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Fan Ni <fan.ni@...sung.com>, linux-cxl@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kyungsan Kim <ks0204.kim@...sung.com>,
        Wonjae Lee <wj28.lee@...sung.com>,
        Hojin Nam <hj96.nam@...sung.com>,
        Junhyeok Im <junhyeok.im@...sung.com>,
        Jehoon Park <jehoon.park@...sung.com>,
        Jeongtae Park <jeongtae.park@...il.com>
Subject: Re: [PATCH 6/7] cxl/memdev: Fix whitespace error/warnings

On Thu, Sep 21, 2023 at 03:57:25PM -0700, Dave Jiang wrote:
> 
> 
> On 9/20/23 19:51, Jeongtae Park wrote:
> > ERROR: code indent should use tabs where possible
> > WARNING: please, no spaces at the start of a line
> > 
> > Signed-off-by: Jeongtae Park <jtp.park@...sung.com>
> 
> two different issues?
> 

Yes, they are. I will seperate and resend them.

> > ---
> >  drivers/cxl/core/memdev.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> > index f99e7ec3cc40..ce67df163452 100644
> > --- a/drivers/cxl/core/memdev.c
> > +++ b/drivers/cxl/core/memdev.c
> > @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl)
> >  }
> >  
> >  static const struct fw_upload_ops cxl_memdev_fw_ops = {
> > -        .prepare = cxl_fw_prepare,
> > -        .write = cxl_fw_write,
> > -        .poll_complete = cxl_fw_poll_complete,
> > -        .cancel = cxl_fw_cancel,
> > -        .cleanup = cxl_fw_cleanup,
> > +	.prepare = cxl_fw_prepare,
> > +	.write = cxl_fw_write,
> > +	.poll_complete = cxl_fw_poll_complete,
> > +	.cancel = cxl_fw_cancel,
> > +	.cleanup = cxl_fw_cleanup,
> >  };
> >  
> >  static void devm_cxl_remove_fw_upload(void *fwl)
> > @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd)
> >  	}
> >  
> >  	return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds);
> > - }
> > +}
> >  
> >  struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds)
> >  {