[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8f24963f-a016-3095-29da-a2fcae5ec9eb@linaro.org>
Date: Thu, 21 Sep 2023 09:01:50 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Abhinav Kumar <quic_abhinavk@...cinc.com>,
Rob Clark <robdclark@...il.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Sean Paul <sean@...rly.run>,
Marijn Suijten <marijn.suijten@...ainline.org>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Kuogee Hsieh <quic_khsieh@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] drm/msm/dpu: Fix SC7280 PP length
On 9/21/23 01:41, Abhinav Kumar wrote:
>
>
> On 9/20/2023 3:46 PM, Konrad Dybcio wrote:
>> Commit 194347df5844 ("drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2
>> macros") unrolled a macro incorrectly. Fix that.
>>
>
> No, its correct from what i can tell.
>
> Before inlining it was using PP_BLK_DITHER macro and not PP_BLK.
>
> PP_BLK_DITHER has a len of 0 and not 0xd4.
>
> Hence I cannot see whats wrong here.
Right, I misread the thing..
Konrad
Powered by blists - more mailing lists