linux-kernel - Re: [PATCH 1/1] arm64: dts: ti: k3-j721e-mcu-wakeup: Add MCU domain ESM instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Sep 2023 20:39:12 +0530
From:   Neha Malcom Francis <n-francis@...com>
To:     "Kumar, Udit" <u-kumar1@...com>, <robh+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>
Subject: Re: [PATCH 1/1] arm64: dts: ti: k3-j721e-mcu-wakeup: Add MCU domain
 ESM instance

Hi Udit

On 21-Sep-23 4:29 PM, Kumar, Udit wrote:
> 
> On 9/20/2023 12:00 PM, Neha Malcom Francis wrote:
>> Currently J721E defines only the main_esm in DTS. Add node for mcu_esm
>> as well.
> Could you please add some more description in commit message , why we 
> need mcu_esm node.

Yes I will add that in, thanks for reviewing!

>> Signed-off-by: Neha Malcom Francis <n-francis@...com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi 
>> b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
>> index 05d6ef127ba7..fa8af20c7818 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
>> @@ -671,4 +671,11 @@ wkup_vtm0: temperature-sensor@...40000 {
>>           power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>;
>>           #thermal-sensor-cells = <1>;
>>       };
>> +
>> +    mcu_esm: esm@...00000 {
>> +        compatible = "ti,j721e-esm";
>> +        reg = <0x00 0x40800000 0x00 0x1000>;
>> +        ti,esm-pins = <95>;
>> +        bootph-pre-ram;
>> +    };
>>   };
> 
> With that change
> 
> Reviewed-by: Udit Kumar <u-kumar1@...com>
> 
> 

Thanking You
Neha Malcom Francis