| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <f8e0caab-32f4-bae4-ef0d-1511c48d67e2@collabora.com>
Date: Fri, 22 Sep 2023 13:36:08 -0300
From: Helen Koike <helen.koike@...labora.com>
To: Vignesh Raman <vignesh.raman@...labora.com>, airlied@...il.com,
daniel@...ll.ch
Cc: daniels@...labora.com, emma@...olt.net,
gustavo.padovan@...labora.com, linux-arm-msm@...r.kernel.org,
guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
virtualization@...ts.linux-foundation.org,
david.heidelberg@...labora.com, linux-mediatek@...ts.infradead.org,
linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v4 5/7] drm: ci: Update xfails
Hi o/
On 14/09/2023 05:54, Vignesh Raman wrote:
> Update amdgpu-stoney-fails, mediatek-mt8173-flakes,
> mediatek-mt8173-fails, rockchip-rk3399-fails, rockchip-rk3399-flakes,
> rockchip-rk3288-flakes, i915-cml-fails, i915-cml-flakes,
> msm-apq8016-flakes files.
>
> Add tests that fail sometimes into the *-flakes file and tests
> that are failing into the *-fails file.
>
> Signed-off-by: Helen Koike <helen.koike@...labora.com>
> Signed-off-by: Vignesh Raman <vignesh.raman@...labora.com>
> ---
>
> v2:
> - No changes
>
> v3:
> - No changes
>
> v4:
> - No changes
>
> ---
> .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 1 -
> drivers/gpu/drm/ci/xfails/i915-cml-fails.txt | 1 -
> drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt | 2 ++
> drivers/gpu/drm/ci/xfails/i915-glk-flakes.txt | 1 +
> .../gpu/drm/ci/xfails/mediatek-mt8173-fails.txt | 2 --
> .../gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt | 16 ++++++++++++++++
> drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt | 2 ++
> .../gpu/drm/ci/xfails/rockchip-rk3288-flakes.txt | 1 +
> .../gpu/drm/ci/xfails/rockchip-rk3399-fails.txt | 4 ++--
> .../gpu/drm/ci/xfails/rockchip-rk3399-flakes.txt | 3 +++
> 10 files changed, 27 insertions(+), 6 deletions(-)
I found an error in the script that updates the flakes from a pipeline,
it was adding errors in *-flakes.txt instead of *-fails.txt even when it
was consistently failing.
I have a partial fix where it works if -flakes.txt is empty (otherwise
it duplicates flakes and fails)
https://gitlab.freedesktop.org/-/snippets/7655
Could you please regenerate these files with this new version of the script?
Btw, I'm improving the script and I'll submit a RFC proposing to include
it as a handy tool in ci folder.
Thanks,
Helen
>
> diff --git a/drivers/gpu/drm/ci/xfails/amdgpu-stoney-fails.txt b/drivers/gpu/drm/ci/xfails/amdgpu-stoney-fails.txt
> index bd9392536e7c..58bfded8a3fc 100644
> --- a/drivers/gpu/drm/ci/xfails/amdgpu-stoney-fails.txt
> +++ b/drivers/gpu/drm/ci/xfails/amdgpu-stoney-fails.txt
> @@ -1,7 +1,6 @@
> kms_addfb_basic@...-pitch-65536,Fail
> kms_addfb_basic@...too-small,Fail
> kms_async_flips@...alid-async-flip,Fail
> -kms_atomic@...ne-immutable-zpos,Fail
> kms_atomic_transition@...ne-toggle-modeset-transition,Fail
> kms_bw@...ear-tiling-1-displays-2560x1440p,Fail
> kms_bw@...ear-tiling-1-displays-3840x2160p,Fail
> diff --git a/drivers/gpu/drm/ci/xfails/i915-cml-fails.txt b/drivers/gpu/drm/ci/xfails/i915-cml-fails.txt
> index 6139b410e767..5f513c638beb 100644
> --- a/drivers/gpu/drm/ci/xfails/i915-cml-fails.txt
> +++ b/drivers/gpu/drm/ci/xfails/i915-cml-fails.txt
> @@ -1,4 +1,3 @@
> -kms_color@...-0-25,Fail
> kms_flip_scaled_crc@...p-32bpp-linear-to-64bpp-linear-downscaling,Fail
> kms_flip_scaled_crc@...p-32bpp-linear-to-64bpp-linear-upscaling,Fail
> kms_flip_scaled_crc@...p-32bpp-xtile-to-64bpp-xtile-downscaling,Fail
> diff --git a/drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt b/drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt
> index 0514a7b3fdb0..f06f1a5b16f9 100644
> --- a/drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt
> +++ b/drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt
> @@ -7,6 +7,8 @@ kms_bw@...ear-tiling-3-displays-3840x2160p
> kms_bw@...ear-tiling-4-displays-1920x1080p
> kms_bw@...ear-tiling-4-displays-2560x1440p
> kms_bw@...ear-tiling-4-displays-3840x2160p
> +kms_color@...-0-25
> +kms_cursor_legacy@...ture-move
> kms_draw_crc@...w-method-xrgb8888-render-xtiled
> kms_flip@...p-vs-suspend
> kms_flip_scaled_crc@...p-32bpp-ytile-to-64bpp-ytile-downscaling
> diff --git a/drivers/gpu/drm/ci/xfails/i915-glk-flakes.txt b/drivers/gpu/drm/ci/xfails/i915-glk-flakes.txt
> index fc41d13a2d56..3aee1f11ee90 100644
> --- a/drivers/gpu/drm/ci/xfails/i915-glk-flakes.txt
> +++ b/drivers/gpu/drm/ci/xfails/i915-glk-flakes.txt
> @@ -8,6 +8,7 @@ kms_bw@...ear-tiling-3-displays-3840x2160p
> kms_bw@...ear-tiling-4-displays-1920x1080p
> kms_bw@...ear-tiling-4-displays-2560x1440p
> kms_bw@...ear-tiling-4-displays-3840x2160p
> +kms_cursor_legacy@...ture-bo
> kms_flip@...cking-wf_vblank
> kms_flip@...vblank-ts-check
> kms_flip@...vblank-ts-check-interruptible
> diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt
> index 671916067dba..c8e64bbfd480 100644
> --- a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt
> +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt
> @@ -1,5 +1,4 @@
> kms_3d,Fail
> -kms_addfb_basic@...fb25-bad-modifier,Fail
> kms_bw@...ear-tiling-1-displays-1920x1080p,Fail
> kms_bw@...ear-tiling-1-displays-2560x1440p,Fail
> kms_bw@...ear-tiling-1-displays-3840x2160p,Fail
> @@ -11,7 +10,6 @@ kms_bw@...ear-tiling-3-displays-2560x1440p,Fail
> kms_bw@...ear-tiling-3-displays-3840x2160p,Fail
> kms_color@...e-A-invalid-gamma-lut-sizes,Fail
> kms_color@...e-B-invalid-gamma-lut-sizes,Fail
> -kms_force_connector_basic@...ce-connector-state,Fail
> kms_force_connector_basic@...ce-edid,Fail
> kms_force_connector_basic@...ce-load-detect,Fail
> kms_force_connector_basic@...ne-stale-modes,Fail
> diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt
> index e69de29bb2d1..9ed6722df2c2 100644
> --- a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt
> +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt
> @@ -0,0 +1,16 @@
> +core_setmaster_vs_auth
> +kms_addfb_basic@...fb25-bad-modifier
> +kms_color@...alid-gamma-lut-sizes
> +kms_cursor_legacy@...sor-vs-flip-atomic
> +kms_cursor_legacy@...sor-vs-flip-legacy
> +kms_force_connector_basic@...ce-connector-state
> +kms_hdmi_inject@...ect-4k
> +kms_plane_scaling@...ne-scaler-with-pixel-format-unity-scaling
> +kms_plane_scaling@...ne-upscale-with-modifiers-20x20
> +kms_plane_scaling@...ne-upscale-with-pixel-format-20x20
> +kms_plane_scaling@...ne-upscale-with-rotation-20x20
> +kms_plane_scaling@...nes-downscale-factor-0-25-upscale-20x20
> +kms_plane_scaling@...nes-downscale-factor-0-5-upscale-20x20
> +kms_plane_scaling@...nes-downscale-factor-0-75-upscale-20x20
> +kms_prop_blob@...alid-set-prop
> +kms_prop_blob@...alid-set-prop-any
> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt
> index 0e3b60d3fade..cd48a8c1d569 100644
> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt
> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt
> @@ -1,3 +1,5 @@
> +kms_cursor_legacy@...ked-bo
> +kms_cursor_legacy@...ked-move
> kms_force_connector_basic@...ce-connector-state
> kms_force_connector_basic@...ce-edid
> kms_force_connector_basic@...ce-load-detect
> diff --git a/drivers/gpu/drm/ci/xfails/rockchip-rk3288-flakes.txt b/drivers/gpu/drm/ci/xfails/rockchip-rk3288-flakes.txt
> index 45c54c75c899..081fe6f8d488 100644
> --- a/drivers/gpu/drm/ci/xfails/rockchip-rk3288-flakes.txt
> +++ b/drivers/gpu/drm/ci/xfails/rockchip-rk3288-flakes.txt
> @@ -1,6 +1,7 @@
> kms_addfb_basic@...fb25-bad-modifier
> kms_cursor_crc@.*
> kms_flip@...ic-flip-vs-wf_vblank
> +kms_flip@...cking-wf_vblank
> kms_invalid_mode@...-max-clock,Crash
> kms_pipe_crc_basic@.*
> kms_properties@...nector-properties-atomic,Crash
> diff --git a/drivers/gpu/drm/ci/xfails/rockchip-rk3399-fails.txt b/drivers/gpu/drm/ci/xfails/rockchip-rk3399-fails.txt
> index 6db08ba6b008..029a3be3164d 100644
> --- a/drivers/gpu/drm/ci/xfails/rockchip-rk3399-fails.txt
> +++ b/drivers/gpu/drm/ci/xfails/rockchip-rk3399-fails.txt
> @@ -2,14 +2,13 @@ kms_color@...acy-gamma,Fail
> kms_color@...e-A-legacy-gamma,Fail
> kms_color@...e-B-legacy-gamma,Fail
> kms_flip@...ic-flip-vs-wf_vblank,Fail
> -kms_flip@...cking-wf_vblank,Fail
> kms_flip@...s-vs-vblank-race,Fail
> kms_flip@...p-vs-absolute-wf_vblank,Fail
> kms_flip@...p-vs-absolute-wf_vblank-interruptible,Fail
> kms_flip@...p-vs-blocking-wf-vblank,Fail
> kms_flip@...p-vs-panning,Fail
> kms_flip@...p-vs-panning-interruptible,Fail
> -kms_flip@...p-vs-wf_vblank-interruptible,Fail
> +kms_flip@...eset-vs-vblank-race,Fail
> kms_flip@...in-flip-fb-recreate,Fail
> kms_flip@...in-flip-fb-recreate-interruptible,Fail
> kms_flip@...in-flip-ts-check,Fail
> @@ -35,3 +34,4 @@ kms_plane_multiple@...mic-pipe-B-tiling-none,Fail
> kms_plane_multiple@...ing-none,Fail
> kms_prime@...ic-crc,Fail
> kms_rmfb@...se-fd,Fail
> +kms_universal_plane@...versal-plane-pipe-B-functional,Fail
> diff --git a/drivers/gpu/drm/ci/xfails/rockchip-rk3399-flakes.txt b/drivers/gpu/drm/ci/xfails/rockchip-rk3399-flakes.txt
> index 4c0539b4beaf..869426a02cbd 100644
> --- a/drivers/gpu/drm/ci/xfails/rockchip-rk3399-flakes.txt
> +++ b/drivers/gpu/drm/ci/xfails/rockchip-rk3399-flakes.txt
> @@ -1,7 +1,10 @@
>
> +kms_color@...ma
> kms_cursor_crc@.*
> +kms_flip@...cking-wf_vblank
> kms_flip@...s-vs-vblank-race-interruptible
> kms_flip@...p-vs-expired-vblank
> +kms_flip@...p-vs-wf_vblank-interruptible
> kms_flip@...eset-vs-vblank-race-interruptible
> kms_pipe_crc_basic@.*
> kms_pipe_crc_basic@...pare-crc-sanitycheck-pipe-A
Powered by blists - more mailing lists