linux-kernel - Re: [PATCH v2] ASoC: dt-bindings: tfa9879: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230922-scoreless-battalion-8b33e36066eb@spud>
Date:   Fri, 22 Sep 2023 19:21:16 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Bragatheswaran Manickavel <bragathemanick0908@...il.com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: tfa9879: Convert to dtschema

On Fri, Sep 22, 2023 at 10:53:06PM +0530, Bragatheswaran Manickavel wrote:
> 
> On 22/09/23 20:56, Conor Dooley wrote:
> > On Fri, Sep 22, 2023 at 12:03:13AM +0530, Bragatheswaran Manickavel wrote:
> > > Convert the tfa9879 audio CODEC bindings to DT schema
> > > No error/warning seen when running make dt_binding_check
> > > 
> > > Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@...il.com>
> > > Changes:
> > > V1 -> V2: Fixed DT syntax errors and doc warning
> > These should be under the --- line, not above it.
> > Perhaps Mark will change it on application.
> > Otherwise,
> > Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> Thanks for reviewing it.
> Do I need to send a new patch by addressing the above comments ?

To be clear, it's the changelog, not the sign off, that needs to go
under the ---. It'd look like:

Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@...il.com>
---
Changes:
V1 -> V2: Fixed DT syntax errors and doc warning

Mark often fixes these things when he applies patches, but sending a v2
w/ the changelog fixed might make his life easier.

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)