linux-kernel - Re: [RFC] ata: libata: increase PMP SRST timeout to 10s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55ab5197-51ba-87bf-e24d-44ebc45f13d7@kernel.org>
Date:   Fri, 22 Sep 2023 13:05:46 -0700
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Matthias Schiffer <mschiffer@...verse-factory.net>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] ata: libata: increase PMP SRST timeout to 10s

On 2023/09/22 12:41, Matthias Schiffer wrote:
>>> Even with the latest series applied, I still need my
>>> ATA_TMOUT_PMP_SRST_WAIT change to avoid the "softreset failed (1st FIS
>>> failed)" message (and get "softreset failed (device not ready)" instead).
>>
>> OK. Thank you for testing.
>> For increasing the timeout, please send a proper patch. I will queue it.
>>
>>
> 
> Will do. Do you see any downsides to the increased timeout? Otherwise, I'd 
> simply add a Fixes: tag for the last time the timeout was touched in 
> e7d3ef13d52a126438f687a1a32da65ff926ed57.

No, I do not see any downside. Most drives do not need such long timeout for
replying to a reset, so it should not be an issue. Increasing to 10s should be
OK. But please be sure to mention in the commit message the adapter and drive
you have that need this, so that we keep a trace of it.


-- 
Damien Le Moal
Western Digital Research