linux-kernel - RE: [PATCH v1 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <005e01d9ed63$4b605550$e220fff0$@opensource.cirrus.com>
Date:   Fri, 22 Sep 2023 15:44:30 +0100
From:   Stefan Binding <sbinding@...nsource.cirrus.com>
To:     'Takashi Iwai' <tiwai@...e.de>
CC:     'Mark Brown' <broonie@...nel.org>,
        'Jaroslav Kysela' <perex@...ex.cz>,
        'Takashi Iwai' <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>, <patches@...nsource.cirrus.com>
Subject: RE: [PATCH v1 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands



> -----Original Message-----
> From: Takashi Iwai <tiwai@...e.de>
> Sent: Friday, September 22, 2023 3:36 PM
> To: Stefan Binding <sbinding@...nsource.cirrus.com>
> Cc: Mark Brown <broonie@...nel.org>; Jaroslav Kysela
> <perex@...ex.cz>; Takashi Iwai <tiwai@...e.com>; alsa-devel@...a-
> project.org; linux-kernel@...r.kernel.org;
> patches@...nsource.cirrus.com
> Subject: Re: [PATCH v1 0/2] ALSA: cs35l41: prevent old firmwares
using
> unsupported commands
> 
> On Fri, 22 Sep 2023 16:28:16 +0200,
> Stefan Binding wrote:
> >
> > Some systems use older firmware which does not support newer
> commands
> > which are used to enable external boost. For those systems, we can
> > workaround this by writing the registers directly.
> >
> > We can use the firmware version, stored inside cs_dsp, to
determine
> > whether or not the command is supported.
> > To achieve this, it requires a cleanup in the api, to pass the
cs_dsp
> > struct into the function.
> >
> > We can also remove the redundant boolean firmware_running from the
> HDA
> > driver, and use the equivalent state inside cs_dsp.
> 
> So those are fixes needed for 6.6 kernel?  Or they are something
new?

These are to fix the issue that was reported on the Lenovo Legion 7
16ACHg6,
which was introduced after the fixes to CS35L41 HDA System Suspend.

Thanks,
Stefan

> 
> > This chain is based on Mark's branch, since the api change was
made to
> > the function in sound/soc/codecs/cs35l41-lib.c.
> 
> I'd need a PR from Mark before applying those, then.
> 
> 
> thanks,
> 
> Takashi