linux-kernel - Re: [PATCH] irqchip: renesas-rzg2l: Convert to irq_data_get_irq_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8vK7-98aHZUBMpNpyehjG8pYf_0Vu8NmWq5bS3-eWTRKQ@mail.gmail.com>
Date:   Mon, 25 Sep 2023 08:43:41 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: renesas-rzg2l: Convert to irq_data_get_irq_chip_data()

On Fri, Sep 22, 2023 at 9:09 AM Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
>
> Use the existing irq_data_get_irq_chip_data() helper instead of
> open-coding the same operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/irqchip/irq-renesas-rzg2l.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
> index 4bbfa2b0a4df9b83..c0f3c09affa64511 100644
> --- a/drivers/irqchip/irq-renesas-rzg2l.c
> +++ b/drivers/irqchip/irq-renesas-rzg2l.c
> @@ -131,7 +131,7 @@ static void rzg2l_irqc_irq_enable(struct irq_data *d)
>
>         if (hw_irq >= IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ) {
>                 struct rzg2l_irqc_priv *priv = irq_data_to_priv(d);
> -               unsigned long tint = (uintptr_t)d->chip_data;
> +               unsigned long tint = (uintptr_t)irq_data_get_irq_chip_data(d);
>                 u32 offset = hw_irq - IRQC_TINT_START;
>                 u32 tssr_offset = TSSR_OFFSET(offset);
>                 u8 tssr_index = TSSR_INDEX(offset);
> --
> 2.34.1
>