linux-kernel - Re: [PATCH 2/7] drm/sun4i: dw-hdmi: Remove double encoder cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b96d809490814cce95ec13ef8e21d3d1.mripard@kernel.org>
Date:   Mon, 25 Sep 2023 07:44:15 +0000
From:   "Maxime Ripard" <mripard@...nel.org>
To:     "Jernej Skrabec" <jernej.skrabec@...il.com>
Cc:     airlied@...il.com, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...ts.linux.dev, mripard@...nel.org,
        samuel@...lland.org, wens@...e.org,
        "Maxime Ripard" <mripard@...nel.org>
Subject: Re: [PATCH 2/7] drm/sun4i: dw-hdmi: Remove double encoder cleanup

On Sun, 24 Sep 2023 21:25:59 +0200, Jernej Skrabec wrote:
> It turns out that comment is wrong - dw hdmi driver never does any
> encoder cleanup. In fact, cleanup is done automatically, in destroy
> callback of encoder. Even more, encoder memory will be freed when hdmi
> device is destroyed. However, encoder will be cleaned up after that, in
> drm_mode_config_cleanup(), which is called later. This will cause use
> 
> [ ... ]

Acked-by: Maxime Ripard <mripard@...nel.org>

Thanks!
Maxime