linux-kernel - RE: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot for imx jpeg encoder/decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AM6PR04MB6341C8E7553F66695467C398E7FCA@AM6PR04MB6341.eurprd04.prod.outlook.com>
Date:   Mon, 25 Sep 2023 08:20:59 +0000
From:   Ming Qian <ming.qian@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "Mirela Rabulea (OSS)" <mirela.rabulea@....nxp.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "X.H. Bao" <xiahong.bao@....com>, Eagle Zhou <eagle.zhou@....com>,
        Tao Jiang <tao.jiang_2@....com>,
        dl-linux-imx <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign
 slot for imx jpeg encoder/decoder

>From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>Sent: 2023年9月25日 16:14
>To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
><mirela.rabulea@....nxp.com>; robh+dt@...nel.org; shawnguo@...nel.org
>Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>mchehab@...nel.org; hverkuil-cisco@...all.nl; s.hauer@...gutronix.de;
>kernel@...gutronix.de; festevam@...il.com; X.H. Bao
><xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>; Tao Jiang
><tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>;
>devicetree@...r.kernel.org; linux-media@...r.kernel.org; linux-
>kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
>Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot
>for imx jpeg encoder/decoder
>
>Caution: This is an external email. Please take care when clicking links or
>opening attachments. When in doubt, report the message using the 'Report
>this email' button
>
>
>On 25/09/2023 10:13, Ming Qian wrote:
>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> Sent: 2023年9月25日 16:10
>>> To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
>>> <mirela.rabulea@....nxp.com>; robh+dt@...nel.org;
>shawnguo@...nel.org
>>> Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>>> mchehab@...nel.org; hverkuil-cisco@...all.nl; s.hauer@...gutronix.de;
>>> kernel@...gutronix.de; festevam@...il.com; X.H. Bao
>>> <xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>; Tao Jiang
>>> <tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>;
>>> devicetree@...r.kernel.org; linux-media@...r.kernel.org; linux-
>>> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg:
>>> Assign slot for imx jpeg encoder/decoder
>>>
>>> Caution: This is an external email. Please take care when clicking
>>> links or opening attachments. When in doubt, report the message using
>>> the 'Report this email' button
>>>
>>>
>>> On 25/09/2023 10:07, Ming Qian wrote:
>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>>> Sent: 2023年9月25日 16:02
>>>>> To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
>>>>> <mirela.rabulea@....nxp.com>; robh+dt@...nel.org;
>>> shawnguo@...nel.org
>>>>> Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>>>>> mchehab@...nel.org; hverkuil-cisco@...all.nl;
>>>>> s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
>>>>> X.H. Bao <xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>;
>>>>> Tao Jiang <tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>;
>>>>> devicetree@...r.kernel.org; linux-media@...r.kernel.org; linux-
>>>>> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg:
>>>>> Assign slot for imx jpeg encoder/decoder
>>>>>
>>>>> Caution: This is an external email. Please take care when clicking
>>>>> links or opening attachments. When in doubt, report the message
>>>>> using the 'Report this email' button
>>>>>
>>>>>
>>>>> On 25/09/2023 09:41, Ming Qian wrote:
>>>>>> There are total 4 slots available in the IP, and we only need to
>>>>>> use one slot in one os, assign a single slot, configure interrupt
>>>>>> and power domain only for 1 slot, not for the all 4 slots.
>>>>>
>>>>> No changelog and I do not see much of improvements. Do not ignore
>>>>> the feedback but respond to it or fix the patch. Really, what happened
>here?
>>>>>
>>>>
>>>> Hi Krzysztof,
>>>>    What do you mean wrap commit message? Do you mean line wrapped
>at
>>> 75 columns?
>>>>
>>>>   - The body of the explanation, line wrapped at 75 columns, which will
>>>>     be copied to the permanent changelog to describe this patch.
>>>
>>> I gave you clear link to the doc explaining this. What is unclear there?
>>>
>>> And you decide to ignore all the rest of the comments here as well?
>
>So this is still ignored? Can you respond to all my comments?
>
>>>
>>> Best regards,
>>> Krzysztof
>>
>> The link content is as below:
>>
>>   - The body of the explanation, line wrapped at 75 columns, which will
>>     be copied to the permanent changelog to describe this patch.
>>
>> I'm sorry that I didn’t get your point.
>
>Wrap
>your
>commit
>according
>to
>coding
>style.
>
>Best regards,
>Krzysztof

Hi Krzysztof,
    I opened your link about the Linux coding style / submission process, but I only find the following message:

  - The body of the explanation, line wrapped at 75 columns, which will
    be copied to the permanent changelog to describe this patch.

     So I don't know what do you mean the coding style.