[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <df86ea4b-d389-4060-bd3b-830bacabde1c@linaro.org>
Date: Mon, 25 Sep 2023 10:33:26 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Ming Qian <ming.qian@....com>,
"Mirela Rabulea (OSS)" <mirela.rabulea@....nxp.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"shawnguo@...nel.org" <shawnguo@...nel.org>
Cc: "krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"mchehab@...nel.org" <mchehab@...nel.org>,
"hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"festevam@...il.com" <festevam@...il.com>,
"X.H. Bao" <xiahong.bao@....com>, Eagle Zhou <eagle.zhou@....com>,
Tao Jiang <tao.jiang_2@....com>,
dl-linux-imx <linux-imx@....com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign
slot for imx jpeg encoder/decoder
On 25/09/2023 10:20, Ming Qian wrote:
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Sent: 2023年9月25日 16:14
>> To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
>> <mirela.rabulea@....nxp.com>; robh+dt@...nel.org; shawnguo@...nel.org
>> Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>> mchehab@...nel.org; hverkuil-cisco@...all.nl; s.hauer@...gutronix.de;
>> kernel@...gutronix.de; festevam@...il.com; X.H. Bao
>> <xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>; Tao Jiang
>> <tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>;
>> devicetree@...r.kernel.org; linux-media@...r.kernel.org; linux-
>> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot
>> for imx jpeg encoder/decoder
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On 25/09/2023 10:13, Ming Qian wrote:
>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>> Sent: 2023年9月25日 16:10
>>>> To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
>>>> <mirela.rabulea@....nxp.com>; robh+dt@...nel.org;
>> shawnguo@...nel.org
>>>> Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>>>> mchehab@...nel.org; hverkuil-cisco@...all.nl; s.hauer@...gutronix.de;
>>>> kernel@...gutronix.de; festevam@...il.com; X.H. Bao
>>>> <xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>; Tao Jiang
>>>> <tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>;
>>>> devicetree@...r.kernel.org; linux-media@...r.kernel.org; linux-
>>>> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
>>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg:
>>>> Assign slot for imx jpeg encoder/decoder
>>>>
>>>> Caution: This is an external email. Please take care when clicking
>>>> links or opening attachments. When in doubt, report the message using
>>>> the 'Report this email' button
>>>>
>>>>
>>>> On 25/09/2023 10:07, Ming Qian wrote:
>>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>>>> Sent: 2023年9月25日 16:02
>>>>>> To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
>>>>>> <mirela.rabulea@....nxp.com>; robh+dt@...nel.org;
>>>> shawnguo@...nel.org
>>>>>> Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>>>>>> mchehab@...nel.org; hverkuil-cisco@...all.nl;
>>>>>> s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
>>>>>> X.H. Bao <xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>;
>>>>>> Tao Jiang <tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>;
>>>>>> devicetree@...r.kernel.org; linux-media@...r.kernel.org; linux-
>>>>>> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
>>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg:
>>>>>> Assign slot for imx jpeg encoder/decoder
>>>>>>
>>>>>> Caution: This is an external email. Please take care when clicking
>>>>>> links or opening attachments. When in doubt, report the message
>>>>>> using the 'Report this email' button
>>>>>>
>>>>>>
>>>>>> On 25/09/2023 09:41, Ming Qian wrote:
>>>>>>> There are total 4 slots available in the IP, and we only need to
>>>>>>> use one slot in one os, assign a single slot, configure interrupt
>>>>>>> and power domain only for 1 slot, not for the all 4 slots.
>>>>>>
>>>>>> No changelog and I do not see much of improvements. Do not ignore
>>>>>> the feedback but respond to it or fix the patch. Really, what happened
>> here?
>>>>>>
>>>>>
>>>>> Hi Krzysztof,
>>>>> What do you mean wrap commit message? Do you mean line wrapped
>> at
>>>> 75 columns?
>>>>>
>>>>> - The body of the explanation, line wrapped at 75 columns, which will
>>>>> be copied to the permanent changelog to describe this patch.
>>>>
>>>> I gave you clear link to the doc explaining this. What is unclear there?
>>>>
>>>> And you decide to ignore all the rest of the comments here as well?
>>
>> So this is still ignored? Can you respond to all my comments?
>>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> The link content is as below:
>>>
>>> - The body of the explanation, line wrapped at 75 columns, which will
>>> be copied to the permanent changelog to describe this patch.
>>>
>>> I'm sorry that I didn’t get your point.
>>
>> Wrap
>> your
>> commit
>> according
>> to
>> coding
>> style.
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
> I opened your link about the Linux coding style / submission process, but I only find the following message:
>
> - The body of the explanation, line wrapped at 75 columns, which will
> be copied to the permanent changelog to describe this patch.
>
> So I don't know what do you mean the coding style.
Linked document explains what is a patch, how it is formatted. Just read
entire doc, not one sentence.
You keep ignoring my other comments all the time, so I will stop asking
you to respond to them. Instead I will be NAK-ing your patches till you
decide to respond.
Best regards,
Krzysztof
Powered by blists - more mailing lists