linux-kernel - Re: [PATCH] arm64: dts: Add watchdog node for Amlogic-C3 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc8fa418-e913-1bea-2f1f-6d7a0e331c29@amlogic.com>
Date:   Mon, 25 Sep 2023 19:07:05 +0800
From:   Huqiang Qin <huqiang.qin@...ogic.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        neil.armstrong@...aro.org, khilman@...libre.com,
        jbrunet@...libre.com, martin.blumenstingl@...glemail.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: Add watchdog node for Amlogic-C3 SoCs


On 2023/9/25 18:58, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 25/09/2023 12:45, Krzysztof Kozlowski wrote:
>> On 25/09/2023 12:42, Huqiang Qin wrote:
>>> Hi Krzysztof,
>>>
>>> On 2023/9/25 17:33, Krzysztof Kozlowski wrote:
>>>> This is c3, not t7. Why do you use t7 compatible alone?
>>>
>>> The C3 and T7 use the same watchdog controller, so they are compatible.
>>
>> I am not saying that they are not compatible. I am saying that different
>> SoCs should use the same compatible. Just like for every other platform,
> 
> Eh, missing "not", so "should not use":
> 
> I am not saying that they are not compatible. I am saying that different
> SoCs should not use the same compatible. Just like for every other
> platform, Amlogic is not special here.
> 
>> Amlogic is not special here.
>>
>> https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst
> 
> Please define compatibility list with t7 as fallback.

Okay, got it, I will modify it in the next version.

Thanks


Best regards,
Huqiang Qin