linux-kernel - Re: [PATCH] irqchip/riscv-intc: Mark INTC nodes for secondary CPUs as initialized.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2023 04:44:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dmitry Dunaev <dunaev@...on.ru>
Cc:     oe-kbuild-all@...ts.linux.dev, dunaich@...l.ru,
        Dmitry Dunaev <dunaev@...on.ru>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] irqchip/riscv-intc: Mark INTC nodes for secondary CPUs
 as initialized.

Hi Dmitry,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on linus/master v6.6-rc3 next-20230926]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Dunaev/irqchip-riscv-intc-Mark-INTC-nodes-for-secondary-CPUs-as-initialized/20230926-183500
base:   tip/irq/core
patch link:    https://lore.kernel.org/r/20230926102801.1591126-1-dunaev%40tecon.ru
patch subject: [PATCH] irqchip/riscv-intc: Mark INTC nodes for secondary CPUs as initialized.
config: riscv-randconfig-001-20230926 (https://download.01.org/0day-ci/archive/20230927/202309270417.HR9Q4rJN-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230927/202309270417.HR9Q4rJN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309270417.HR9Q4rJN-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/irqchip/irq-riscv-intc.c: In function 'riscv_intc_acpi_init':
>> drivers/irqchip/irq-riscv-intc.c:185:58: error: 'node' undeclared (first use in this function)
     185 |                 fwnode_dev_initialized(of_node_to_fwnode(node), true);
         |                                                          ^~~~
   drivers/irqchip/irq-riscv-intc.c:185:58: note: each undeclared identifier is reported only once for each function it appears in

vim +/node +185 drivers/irqchip/irq-riscv-intc.c

   169	
   170	static int __init riscv_intc_acpi_init(union acpi_subtable_headers *header,
   171					       const unsigned long end)
   172	{
   173		struct fwnode_handle *fn;
   174		struct acpi_madt_rintc *rintc;
   175	
   176		rintc = (struct acpi_madt_rintc *)header;
   177	
   178		/*
   179		 * The ACPI MADT will have one INTC for each CPU (or HART)
   180		 * so riscv_intc_acpi_init() function will be called once
   181		 * for each INTC. We only do INTC initialization
   182		 * for the INTC belonging to the boot CPU (or boot HART).
   183		 */
   184		if (riscv_hartid_to_cpuid(rintc->hart_id) != smp_processor_id()) {
 > 185			fwnode_dev_initialized(of_node_to_fwnode(node), true);
   186			return 0;
   187		}
   188	
   189		fn = irq_domain_alloc_named_fwnode("RISCV-INTC");
   190		if (!fn) {
   191			pr_err("unable to allocate INTC FW node\n");
   192			return -ENOMEM;
   193		}
   194	
   195		return riscv_intc_init_common(fn);
   196	}
   197	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki