linux-kernel - Re: [PATCH] irqchip/riscv-intc: Mark INTC nodes for secondary CPUs as initialized.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86il7mofmm.wl-maz@kernel.org>
Date:   Wed, 04 Oct 2023 11:18:09 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Anup Patel <apatel@...tanamicro.com>
Cc:     Dmitry Dunaev <dunaev@...on.ru>, dunaich@...l.ru,
        Thomas Gleixner <tglx@...utronix.de>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] irqchip/riscv-intc: Mark INTC nodes for secondary CPUs as initialized.

On Tue, 26 Sep 2023 11:36:31 +0100,
Anup Patel <apatel@...tanamicro.com> wrote:
> 
> On Tue, Sep 26, 2023 at 3:59 PM Dmitry Dunaev <dunaev@...on.ru> wrote:
> >
> > The current Linux driver irq-riscv-intc initialize IRQ domain only once,
> > when init function called on primary hart. In other cases no IRQ domain is
> > created and no operation on interrupt-controller node is performed.
> > This is cause of that no common Linux driver can use per-cpu interrupts
> > mapped to several CPUs because fwnode of secondary cores INTC is not
> > marked as initialized. This device is always will be marked as deferred.
> > For example the system with devicetree
> >
> >     cpu0: cpu@0 {
> >         cpu0_intc: interrupt-controller {
> >             interrupt-controller;
> >             compatible = riscv,cpu-intc;
> >         };
> >     };
> >
> >     cpu1: cpu@1 {
> >         cpu1_intc: interrupt-controller {
> >             interrupt-controller;
> >             compatible = riscv,cpu-intc;
> >         };
> >     };
> >
> >     buserr {
> >         compatible = riscv,buserr;
> >         interrupts-extended = <&cpu0_intc 16 &cpu1_intc 16>;
> >     };
> >
> > will always report 'buserr' node as deferred without calling any
> > bus probe function.
> >
> > This patch will mark all secondary nodes passed to irq-riscv-intc
> > driver init function as initialized to be able to act as correct
> > IRQ phandle node.
> >
> > Signed-off-by: Dmitry Dunaev <dunaev@...on.ru>
> > ---
> >  drivers/irqchip/irq-riscv-intc.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c
> > index 4adeee1bc391..c01a4e8d4983 100644
> > --- a/drivers/irqchip/irq-riscv-intc.c
> > +++ b/drivers/irqchip/irq-riscv-intc.c
> > @@ -155,8 +155,10 @@ static int __init riscv_intc_init(struct device_node *node,
> >          * for each INTC DT node. We only need to do INTC initialization
> >          * for the INTC DT node belonging to boot CPU (or boot HART).
> >          */
> > -       if (riscv_hartid_to_cpuid(hartid) != smp_processor_id())
> > +       if (riscv_hartid_to_cpuid(hartid) != smp_processor_id()) {
> > +               fwnode_dev_initialized(of_node_to_fwnode(node), true);
> 
> There is already a patch on LKML to address this.
> https://www.spinics.net/lists/kernel/msg4929886.html

If this is a fix, why is it buried in a huge series and not brought
forward as an independent fix that needs to be picked early?

	M.

-- 
Without deviation from the norm, progress is not possible.