linux-kernel - Re: [PATCH V4 4/7] ASoC: codecs: Add code for bin parsing compatible with aw87390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230926070436.486530-1-wangweidong.a@awinic.com>
Date:   Tue, 26 Sep 2023 15:04:30 +0800
From:   wangweidong.a@...nic.com
To:     broonie@...nel.org
Cc:     13916275206@....com, alsa-devel@...a-project.org, arnd@...db.de,
        ckeepax@...nsource.cirrus.com, colin.i.king@...il.com,
        conor+dt@...nel.org, devicetree@...r.kernel.org,
        harshit.m.mogalapalli@...cle.com, herve.codina@...tlin.com,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
        liweilei@...nic.com, perex@...ex.cz, povik+lin@...ebit.org,
        rf@...nsource.cirrus.com, robh+dt@...nel.org, ryans.lee@...log.com,
        shumingf@...ltek.com, tiwai@...e.com, trix@...hat.com,
        u.kleine-koenig@...gutronix.de, wangweidong.a@...nic.com,
        yang.lee@...ux.alibaba.com, yijiangtao@...nic.com
Subject: Re: [PATCH V4 4/7] ASoC: codecs: Add code for bin parsing compatible with aw87390

Thank you very much for your review, but there's something I'd like to discuss with you

On Mon, Sep 25, 2023 at 16:06:18 +0200, broonie@...nel.org wrote:
> On Tue, Sep 19, 2023 at 06:57:21PM +0800, wangweidong.a@...nic.com wrote:
>> From: Weidong Wang <wangweidong.a@...nic.com>
>> 
>> Add aw87390 compatible code to the aw88395_lib.c file
>> so that it can parse aw87390's bin file
>> Modify the function return value

> This breaks an x86 allmodconfig build:

> /build/stage/linux/sound/soc/codecs/aw88395/aw88395.c: In function ‘aw88395_prof
> ile_info’:
> /build/stage/linux/sound/soc/codecs/aw88395/aw88395.c:199:21: error: too few arg
> uments to function ‘aw88395_dev_get_prof_name’
>  199 |         prof_name = aw88395_dev_get_prof_name(aw88395->aw_pa, count);
>      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /build/stage/linux/sound/soc/codecs/aw88395/aw88395.c:17:
> /build/stage/linux/sound/soc/codecs/aw88395/aw88395_device.h:184:5: note: declar
> ed here
>  184 | int aw88395_dev_get_prof_name(struct aw_device *aw_dev, int index, char 
> **prof_name);
>      |     ^~~~~~~~~~~~~~~~~~~~~~~~~

I did not get this error when compiling base on "2cf0f715623872823a72e451243bbf555d10d032"
and the changes to this function are already in [patch V4 3/7]
Can you tell me how to modify it?

Best regards,
Weidong Wang