linux-kernel - Re: [PATCH v2] spi: omap2-mcspi: Fix hardcoded reference clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRLH6JbEABFrfQMw@finisterre.sirena.org.uk>
Date:   Tue, 26 Sep 2023 14:00:40 +0200
From:   Mark Brown <broonie@...nel.org>
To:     Dhruva Gole <d-gole@...com>
Cc:     Vaishnav Achath <vaishnav.a@...com>, linux-spi@...r.kernel.org,
        vigneshr@...com, linux-kernel@...r.kernel.org, u-kumar1@...com
Subject: Re: [PATCH v2] spi: omap2-mcspi: Fix hardcoded reference clock

On Tue, Sep 26, 2023 at 05:25:54PM +0530, Dhruva Gole wrote:
> On Sep 26, 2023 at 17:08:12 +0530, Vaishnav Achath wrote:

> > +	ctlr->max_speed_hz = mcspi->ref_clk_hz;
> > +	ctlr->min_speed_hz = mcspi->ref_clk_hz >> 15;

> nit: Can we improve on previous code by making 15 into a macro?

I'll queue this for CI now, please send an incremental fix for this
style issue with the constant.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)