linux-kernel - Re: [PATCH] LoongArch: numa: Fix high

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Sep 2023 23:26:30 +0800
From:   WANG Xuerui <kernel@...0n.name>
To:     Huacai Chen <chenhuacai@...ngson.cn>,
        Arnd Bergmann <arnd@...db.de>,
        Huacai Chen <chenhuacai@...nel.org>
Cc:     loongarch@...ts.linux.dev, linux-arch@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Guo Ren <guoren@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-kernel@...r.kernel.org, loongson-kernel@...ts.loongnix.cn,
        stable@...r.kernel.org, Chong Qiao <qiaochong@...ngson.cn>
Subject: Re: [PATCH] LoongArch: numa: Fix high_memory calculation

On 9/26/23 20:10, Huacai Chen wrote:
> high_memory is the virtual address of the 'highest physical address' in
> the system. But __va(get_num_physpages() << PAGE_SHIFT) is not what we
> want because there may be holes in the physical address space. On the
> other hand, max_low_pfn is calculated from memblock_end_of_DRAM(), which
> is exactly corresponding to the highest physical address, so use it for
> high_memory calculation.
>
> Cc: <stable@...r.kernel.org>
Which commit is this patch intended to amend? A "Fixes:" tag may be 
helpful for stable backporting.
> Signed-off-by: Chong Qiao <qiaochong@...ngson.cn>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---
>   arch/loongarch/kernel/numa.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/numa.c b/arch/loongarch/kernel/numa.c
> index c7d33c489e04..6e65ff12d5c7 100644
> --- a/arch/loongarch/kernel/numa.c
> +++ b/arch/loongarch/kernel/numa.c
> @@ -436,7 +436,7 @@ void __init paging_init(void)
>   
>   void __init mem_init(void)
>   {
> -	high_memory = (void *) __va(get_num_physpages() << PAGE_SHIFT);
> +	high_memory = (void *) __va(max_low_pfn << PAGE_SHIFT);
>   	memblock_free_all();
>   }
>   

-- 
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/