linux-kernel - Re: [PATCH next v4 0/5] minmax: Relax type checks in min() and max().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230927103014.683e41b855cb2cd4ea163fa5@linux-foundation.org>
Date:   Wed, 27 Sep 2023 10:30:14 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>,
        "'Matthew Wilcox (Oracle)'" <willy@...radead.org>,
        'Christoph Hellwig' <hch@...radead.org>,
        "'Jason A. Donenfeld'" <Jason@...c4.com>
Subject: Re: [PATCH next v4 0/5] minmax: Relax type checks in min() and
 max().

On Mon, 18 Sep 2023 08:14:40 +0000 David Laight <David.Laight@...LAB.COM> wrote:

> A quick grep shows 5734 min() and 4597 min_t().
> Having the casts on almost half of the calls shows that something
> is clearly wrong.

My preferred approach to fixing min() warnings is "the types are wrong".
But often getting the types better is hard.

Is there a plan afoot to go around existing code doing some
min_t()->min() conversions?