linux-kernel - RE: [PATCH next v4 0/5] minmax: Relax type checks in min() and max().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b03cbd61c104b1db0848f3ad900a2ea@AcuMS.aculab.com>
Date:   Thu, 28 Sep 2023 08:10:09 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Andrew Morton' <akpm@...ux-foundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Linus Torvalds" <torvalds@...ux-foundation.org>,
        'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>,
        "'Matthew Wilcox (Oracle)'" <willy@...radead.org>,
        'Christoph Hellwig' <hch@...radead.org>,
        "'Jason A. Donenfeld'" <Jason@...c4.com>
Subject: RE: [PATCH next v4 0/5] minmax: Relax type checks in min() and max().

From: Andrew Morton
> Sent: 27 September 2023 18:30
> 
> On Mon, 18 Sep 2023 08:14:40 +0000 David Laight <David.Laight@...LAB.COM> wrote:
> 
> > A quick grep shows 5734 min() and 4597 min_t().
> > Having the casts on almost half of the calls shows that something
> > is clearly wrong.

Thanks for taking these.
I had a horrid thought they were languishing again.

> My preferred approach to fixing min() warnings is "the types are wrong".
> But often getting the types better is hard.
> 
> Is there a plan afoot to go around existing code doing some
> min_t()->min() conversions?

Could get tedious given there are 4500+ min_t() out there.
Also every one needs looking at just to check it isn't relying
on the cast - a few do,

But they could get reduced slowly.
Not adding more would be a bonus!

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)