linux-kernel - Re: [PATCH v3] list: test: potential dereference of null pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2023 11:24:50 +0800
From:   David Gow <davidgow@...gle.com>
To:     Ma Ke <make_ruc2021@....com>
Cc:     linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] list: test: potential dereference of null pointer

On Sat, 23 Sept 2023 at 08:54, Ma Ke <make_ruc2021@....com> wrote:
>
> To avoid the failure of alloc, we could check the return value of
> kmalloc() and kzalloc().
>
> Signed-off-by: Ma Ke <make_ruc2021@....com>
> ---

Thanks very much. This looks good to me. We could change the rest of
the allocations to also use kunit_kzalloc(), but equally that can be
left to another patch.

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

>  lib/list-test.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/list-test.c b/lib/list-test.c
> index 0cc27de9cec8..a0b478042477 100644
> --- a/lib/list-test.c
> +++ b/lib/list-test.c
> @@ -26,10 +26,12 @@ static void list_test_list_init(struct kunit *test)
>
>         INIT_LIST_HEAD(&list2);
>
> -       list4 = kzalloc(sizeof(*list4), GFP_KERNEL | __GFP_NOFAIL);
> +       list4 = kunit_kzalloc(test, sizeof(*list4), GFP_KERNEL | __GFP_NOFAIL);
> +       KUNIT_ASSERT_NOT_NULL(test, list4);
>         INIT_LIST_HEAD(list4);
>
>         list5 = kmalloc(sizeof(*list5), GFP_KERNEL | __GFP_NOFAIL);
> +       KUNIT_ASSERT_NOT_NULL(test, list5);
>         memset(list5, 0xFF, sizeof(*list5));
>         INIT_LIST_HEAD(list5);
>
> @@ -40,7 +42,6 @@ static void list_test_list_init(struct kunit *test)
>         KUNIT_EXPECT_TRUE(test, list_empty_careful(list4));
>         KUNIT_EXPECT_TRUE(test, list_empty_careful(list5));
>
> -       kfree(list4);
>         kfree(list5);
>  }
>
> --
> 2.37.2
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)