linux-kernel - Re: [PATCH v7 01/12] ext4: make state in ext4_mb_mark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <874jjggn8l.fsf@doe.com>
Date:   Wed, 27 Sep 2023 11:40:34 +0530
From:   Ritesh Harjani (IBM) <ritesh.list@...il.com>
To:     Kemeng Shi <shikemeng@...weicloud.com>, tytso@....edu,
        adilger.kernel@...ger.ca
Cc:     ojaswin@...ux.ibm.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 01/12] ext4: make state in ext4_mb_mark_bb to be bool

Kemeng Shi <shikemeng@...weicloud.com> writes:

> As state could only be either 0 or 1, just make it bool.

Sure.

>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> ---
>  fs/ext4/ext4.h        | 2 +-
>  fs/ext4/fast_commit.c | 8 ++++----
>  fs/ext4/mballoc.c     | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)

But why not convert at all places?

git grep "ext4_mb_mark_bb" .
fs/ext4/ext4.h:extern void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
fs/ext4/extents.c:                                      ext4_mb_mark_bb(inode->i_sb,
fs/ext4/extents.c:                      ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
fs/ext4/fast_commit.c:                  ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
fs/ext4/fast_commit.c:                  ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
fs/ext4/fast_commit.c:                                          ext4_mb_mark_bb(inode->i_sb,
fs/ext4/fast_commit.c:                          ext4_mb_mark_bb(inode->i_sb, map.m_pblk,
fs/ext4/mballoc.c:void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
fs/ext4/mballoc.c:      ext4_mb_mark_bb(sb, block, 1, 1);

-ritesh