[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ec8aca6c-1e8c-3fe9-81d7-d18876cc40cb@huaweicloud.com>
Date: Wed, 27 Sep 2023 14:51:28 +0800
From: Kemeng Shi <shikemeng@...weicloud.com>
To: Ritesh Harjani <ritesh.list@...il.com>, tytso@....edu,
adilger.kernel@...ger.ca
Cc: ojaswin@...ux.ibm.com, linux-ext4@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 01/12] ext4: make state in ext4_mb_mark_bb to be bool
on 9/27/2023 2:10 PM, Ritesh Harjani wrote:
> Kemeng Shi <shikemeng@...weicloud.com> writes:
>
>> As state could only be either 0 or 1, just make it bool.
>
> Sure.
>
>>
>> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
>> ---
>> fs/ext4/ext4.h | 2 +-
>> fs/ext4/fast_commit.c | 8 ++++----
>> fs/ext4/mballoc.c | 2 +-
>> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> But why not convert at all places?
Sorry for this. Will convert at all places in next version. Thanks.
>
> git grep "ext4_mb_mark_bb" .
> fs/ext4/ext4.h:extern void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
> fs/ext4/extents.c: ext4_mb_mark_bb(inode->i_sb,
> fs/ext4/extents.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb,
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk,
> fs/ext4/mballoc.c:void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
> fs/ext4/mballoc.c: ext4_mb_mark_bb(sb, block, 1, 1);
>
> -ritesh
>
Powered by blists - more mailing lists