linux-kernel - Re: [PATCH] vidio: Clean up errors in serial.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2023 10:22:15 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     chenguohua@...i.cn
Cc:     linux@...linux.org.uk, prathubaronia2011@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vidio: Clean up errors in serial.h

On Wed, Sep 27, 2023 at 02:32:23PM +0800, chenguohua@...i.cn wrote:
> Fix the following errors reported by checkpatch:
> 
> ERROR: space required after that ',' (ctx:VxV)
> 
> Signed-off-by: GuoHua Cheng <chenguohua@...i.cn>

Your subject line is very odd.

> ---
>  include/linux/amba/clcd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/amba/clcd.h b/include/linux/amba/clcd.h
> index b6e0cbeaf533..64df8235d9cc 100644
> --- a/include/linux/amba/clcd.h
> +++ b/include/linux/amba/clcd.h
> @@ -244,7 +244,7 @@ static inline int clcdfb_check(struct clcd_fb *fb, struct fb_var_screeninfo *var
>  	var->xres_virtual = var->xres = (var->xres + 15) & ~15;
>  	var->yres_virtual = var->yres = (var->yres + 1) & ~1;
>  
> -#define CHECK(e,l,h) (var->e < l || var->e > h)
> +#define CHECK(e, l, h) (var->e < l || var->e > h)

There is nothing wrong with the original code here, please do not run
checkpatch on code that is NOT in drivers/staging/ unless you get the
approval of the maintainer to do so.

thanks,

greg k-h