linux-kernel - Re: [PATCH v2 1/2] regulator/core: regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169580465113.2674076.14526284679681937734.b4-ty@kernel.org>
Date:   Wed, 27 Sep 2023 10:50:51 +0200
From:   Mark Brown <broonie@...nel.org>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     Vladimir Zapolskiy <vz@...ia.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] regulator/core: regulator_register: set
 device->class earlier

On Tue, 19 Sep 2023 00:50:26 +0200, Michał Mirosław wrote:
> When fixing a memory leak in commit d3c731564e09 ("regulator: plug
> of_node leak in regulator_register()'s error path") it moved the
> device_initialize() call earlier, but did not move the `dev->class`
> initialization.  The bug was spotted and fixed by reverting part of
> the commit (in commit 5f4b204b6b81 "regulator: core: fix kobject
> release warning and memory leak in regulator_register()") but
> introducing a different bug: now early error paths use `kfree(dev)`
> instead of `put_device()` for an already initialized `struct device`.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator/core: regulator_register: set device->class earlier
      commit: 8adb4e647a83cb5928c05dae95b010224aea0705
[2/2] regulator/core: Revert "fix kobject release warning and memory leak in regulator_register()"
      commit: 6e800968f6a715c0661716d2ec5e1f56ed9f9c08

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark