linux-kernel - Re: [PATCH 00/40] soc: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1b2fddf8-c0a6-4afa-8ad0-f280dea1607f@app.fastmail.com>
Date:   Wed, 27 Sep 2023 10:43:16 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Joel Stanley" <joel@....id.au>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     "Leo Li" <leoyang.li@....com>,
        "Herve Codina" <herve.codina@...tlin.com>,
        "Qiang Zhao" <qiang.zhao@....com>,
        "Hitomi Hasegawa" <hasegawa-hitomi@...itsu.com>,
        "Huisong Li" <lihuisong@...wei.com>,
        "Krzysztof Halasa" <khalasa@...p.pl>,
        "Karol Gugala" <kgugala@...micro.com>,
        "Mateusz Holenko" <mholenko@...micro.com>,
        "Gabriel Somlo" <gsomlo@...il.com>,
        "Yinbo Zhu" <zhuyinbo@...ngson.cn>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        "Conor.Dooley" <conor.dooley@...rochip.com>,
        "Daire McNamara" <daire.mcnamara@...rochip.com>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        "Andy Gross" <agross@...nel.org>,
        "Bjorn Andersson" <andersson@...nel.org>,
        "Konrad Dybcio" <konrad.dybcio@...aro.org>,
        Heiko Stübner <heiko@...ech.de>,
        "Thierry Reding" <thierry.reding@...il.com>,
        "Jon Hunter" <jonathanh@...dia.com>,
        "Sumit Gupta" <sumitg@...dia.com>,
        "Shang XiaoJing" <shangxiaojing@...wei.com>,
        "Muhammad Usama Anjum" <usama.anjum@...labora.com>,
        "Rob Herring" <robh@...nel.org>, "Nishanth Menon" <nm@...com>,
        "Santosh Shilimkar" <ssantosh@...nel.org>,
        "Michal Simek" <michal.simek@....com>,
        "Andrew Jeffery" <andrew@...id.au>,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        "Zev Weiss" <zev@...ilderbeest.net>, linuxppc-dev@...ts.ozlabs.org,
        loongarch@...ts.linux.dev,
        "AngeloGioacchino Del Regno" 
        <angelogioacchino.delregno@...labora.com>,
        linux-mediatek@...ts.infradead.org,
        linux-riscv@...ts.infradead.org,
        "zhang.songyi" <zhang.songyi@....com.cn>,
        "Lubomir Rintel" <lkundrak@...sk>, linux-arm-msm@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        "Alim Akhtar" <alim.akhtar@...sung.com>,
        linux-samsung-soc@...r.kernel.org,
        "Nick Alcock" <nick.alcock@...cle.com>,
        "Yang Yingliang" <yangyingliang@...wei.com>,
        linux-tegra@...r.kernel.org, linux-pm@...r.kernel.org,
        "Ruan Jinjie" <ruanjinjie@...wei.com>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>
Subject: Re: [PATCH 00/40] soc: Convert to platform remove callback returning void

On Wed, Sep 27, 2023, at 04:25, Joel Stanley wrote:
> On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
>>
>> this series converts all platform drivers below drivers/soc to use
>> .remove_new(). The motivation is to get rid of an integer return code
>> that is (mostly) ignored by the platform driver core and error prone on
>> the driver side.
>>
>> See commit 5c5a7680e67b ("platform: Provide a remove callback that
>> returns no value") for an extended explanation and the eventual goal.
>>
>> As there is no single maintainer team for drivers/soc, I suggest the
>> individual maintainers to pick up "their" patches.
>
> I'd be happy if Arnd merged the lot at once. Arnd, what do you think?
>
> If that will be too messy then I understand. I have queued the aspeed
> ones locally and will push that out if we decide that's the best way
> to go.

The main downside of merging it all at once through the soc tree
is that there may be patches that conflict with other work going on
in individual drivers.

What I'd suggest doing here is:

- have platform maintainers pick up patches for their drivers
  if that is their preference for any reason

- get a pull request from Uwe for the soc tree for anything that has
  not been picked up in one or two weeks from now

      Arnd