linux-kernel - Re: [PATCH 00/40] soc: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Sep 2023 08:14:49 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Bjorn Andersson <andersson@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Nishanth Menon <nm@...com>,
        Herve Codina <herve.codina@...tlin.com>,
        Heiko Stübner <heiko@...ech.de>,
        Mateusz Holenko <mholenko@...micro.com>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>,
        linux-tegra@...r.kernel.org,
        "Conor.Dooley" <conor.dooley@...rochip.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        linux-riscv@...ts.infradead.org,
        Karol Gugala <kgugala@...micro.com>,
        Qiang Zhao <qiang.zhao@....com>,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        Rob Herring <robh@...nel.org>,
        linux-samsung-soc@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
        Ruan Jinjie <ruanjinjie@...wei.com>,
        Yinbo Zhu <zhuyinbo@...ngson.cn>,
        Jon Hunter <jonathanh@...dia.com>,
        linux-rockchip@...ts.infradead.org,
        Gabriel Somlo <gsomlo@...il.com>,
        Andy Gross <agross@...nel.org>,
        Huisong Li <lihuisong@...wei.com>,
        Joel Stanley <joel@....id.au>, Sumit Gupta <sumitg@...dia.com>,
        "zhang.songyi" <zhang.songyi@....com.cn>,
        Zev Weiss <zev@...ilderbeest.net>, linux-pm@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Yang Yingliang <yangyingliang@...wei.com>,
        Lubomir Rintel <lkundrak@...sk>,
        Krzysztof Halasa <khalasa@...p.pl>, loongarch@...ts.linux.dev,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Michal Simek <michal.simek@....com>,
        linux-arm-kernel@...ts.infradead.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        linux-kernel@...r.kernel.org,
        Shang XiaoJing <shangxiaojing@...wei.com>,
        Leo Li <leoyang.li@....com>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andrew Jeffery <andrew@...id.au>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-mediatek@...ts.infradead.org,
        Nick Alcock <nick.alcock@...cle.com>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 00/40] soc: Convert to platform remove callback returning
 void

On Wed, Sep 27, 2023 at 04:01:58PM -0700, Bjorn Andersson wrote:
> On Wed, Sep 27, 2023 at 10:43:16AM +0200, Arnd Bergmann wrote:
> > On Wed, Sep 27, 2023, at 04:25, Joel Stanley wrote:
> > > On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
> > >>
> > >> this series converts all platform drivers below drivers/soc to use
> > >> .remove_new(). The motivation is to get rid of an integer return code
> > >> that is (mostly) ignored by the platform driver core and error prone on
> > >> the driver side.
> > >>
> > >> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> > >> returns no value") for an extended explanation and the eventual goal.
> > >>
> > >> As there is no single maintainer team for drivers/soc, I suggest the
> > >> individual maintainers to pick up "their" patches.
> > >
> > > I'd be happy if Arnd merged the lot at once. Arnd, what do you think?
> > >
> > > If that will be too messy then I understand. I have queued the aspeed
> > > ones locally and will push that out if we decide that's the best way
> > > to go.
> > 
> > The main downside of merging it all at once through the soc tree
> > is that there may be patches that conflict with other work going on
> > in individual drivers.
> > 
> > What I'd suggest doing here is:
> > 
> > - have platform maintainers pick up patches for their drivers
> >   if that is their preference for any reason
> 
> I'd prefer this for the qcom drivers at least, please let me know if you
> would like me to proceed.

I can send a pull request as Arnd suggested. So iff you want the qcom
drivers not be a part of that PR, just make sure they appear in next
during the next week. :-)

(I'm not sure if "this" in your last quoted sentence is "platform
maintainers pick up" or "merging it all at once through the soc tree". I
think you mean the former. Still if you don't want me to pick up the
qcom patches and won't manage to make them appear in next via your tree,
I ask you to tell me explicitly to skip these in my PR.)

Best regards and thanks,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)