[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1865054.tdWV9SEqCh@phil>
Date: Mon, 02 Oct 2023 00:58:30 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
Cc: linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel@...gutronix.de
Subject: Re: [PATCH 30/40] soc/rockchip: io-domain: Convert to platform remove
callback returning void
Am Montag, 25. September 2023, 11:55:21 CEST schrieb Uwe Kleine-König:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
applied for 6.7
Thanks
Heiko
Powered by blists - more mailing lists