linux-kernel - Re: [PATCH v13 00/22] TDX host kernel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d71cb084b03f2bc3fc195fa76eb60c2d2bfc917.camel@intel.com>
Date:   Thu, 28 Sep 2023 10:19:17 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "nik.borisov@...e.com" <nik.borisov@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Raj, Ashok" <ashok.raj@...el.com>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "david@...hat.com" <david@...hat.com>,
        "bagasdotme@...il.com" <bagasdotme@...il.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "Shahar, Sagi" <sagis@...gle.com>,
        "imammedo@...hat.com" <imammedo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "Gao, Chao" <chao.gao@...el.com>,
        "Brown, Len" <len.brown@...el.com>,
        "sathyanarayanan.kuppuswamy@...ux.intel.com" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        "Huang, Ying" <ying.huang@...el.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v13 00/22] TDX host kernel support

On Thu, 2023-09-28 at 10:48 +0300, Nikolay Borisov wrote:
> 
> On 25.08.23 г. 15:14 ч., Kai Huang wrote:
> > Intel Trusted Domain Extensions (TDX) protects guest VMs from malicious
> > host and certain physical attacks.  TDX specs are available in [1].
> > 
> > This series is the initial support to enable TDX with minimal code to
> > allow KVM to create and run TDX guests.  KVM support for TDX is being
> > developed separately[2].  A new KVM "guest_memfd()" to support private
> > memory is also being developed[3].  KVM will only support the new
> > "guest_memfd()" infrastructure for TDX.
> > 
> > Also, a few first generations of TDX hardware have an erratum[4], and
> > require additional handing.
> > 
> > This series doesn't aim to support all functionalities, and doesn't aim
> > to resolve all things perfectly.  All other optimizations will be posted
> > as follow-up once this initial TDX support is upstreamed.
> > 
> > Hi Dave/Kirill/Peter/Tony/David and all,
> > 
> > Thanks for your review on the previous versions.  Appreciate your review
> > on this version and any tag if patches look good to you.  Thanks!
> > 
> > This version was based on "Unify TDCALL/SEAMCALL and TDVMCALL assembly"
> > series, which was based on latest tip/x86/tdx, requested by Peter:
> > 
> > https://lore.kernel.org/lkml/cover.1692096753.git.kai.huang@intel.com/
> > 
> > Please also help to review that series.  Thanks!
> > 
> 
> 
> Are there any major outstanding issues preventing this to be merged? The 
> review has been somewhat quiet and most of the outstanding issues seems 
> to be nitpicks?

Hi Nikolay,

I am addressing comments from Rick, e.g., some additional handling to
S3/hibernation is needed.  I'll post the next version soon, which I hope can be
the candidate to be merged.  Thanks!