[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5d27cf14-3df6-1771-9323-c54ede6db587@ti.com>
Date: Thu, 28 Sep 2023 15:46:01 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Roger Quadros <rogerq@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Vignesh Raghavendra <vigneshr@...com>,
Richard Cochran <richardcochran@...il.com>,
Paolo Abeni <pabeni@...hat.com>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
"David S. Miller" <davem@...emloft.net>, <vladimir.oltean@....com>,
Simon Horman <horms@...nel.org>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<srk@...com>, <r-gunasekaran@...com>, Roger Quadros <rogerq@...com>
Subject: Re: [PATCH net-next v2] net: ti: icssg_prueth: add TAPRIO offload
support
On 21/09/23 16:12, Roger Quadros wrote:
> Hi Danish,
>
> On 21/09/2023 10:00, MD Danish Anwar wrote:
>
> Can you please retain patch authorhsip?
>
>> ICSSG dual-emac f/w supports Enhanced Scheduled Traffic (EST – defined
>> in P802.1Qbv/D2.2 that later got included in IEEE 802.1Q-2018)
>> configuration. EST allows express queue traffic to be scheduled
>> (placed) on the wire at specific repeatable time intervals. In
>> Linux kernel, EST configuration is done through tc command and
>> the taprio scheduler in the net core implements a software only
>> scheduler (SCH_TAPRIO). If the NIC is capable of EST configuration,
>> user indicate "flag 2" in the command which is then parsed by
>> taprio scheduler in net core and indicate that the command is to
>> be offloaded to h/w. taprio then offloads the command to the
>> driver by calling ndo_setup_tc() ndo ops. This patch implements
>> ndo_setup_tc() to offload EST configuration to ICSSG.
>>
>> Signed-off-by: Roger Quadros <rogerq@...com>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
>> Signed-off-by: MD Danish Anwar <danishanwar@...com>
>> ---
[ ... ]
>> + if (!netif_running(ndev)) {
>> + netdev_err(ndev, "interface is down, link speed unknown\n");
>> + return -ENETDOWN;
>> + }
>
> Do we really need this?
I don't think this is needed. I will drop this and spin next revision.
--
Thanks and Regards,
Danish
Powered by blists - more mailing lists