linux-kernel - Re: [PATCH v2 1/4] KVM: x86: refactor req_immediate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6939a0d710438c4b3d3d98fb7b81030e9d01a0f.camel@redhat.com>
Date:   Thu, 28 Sep 2023 13:41:09 +0300
From:   Maxim Levitsky <mlevitsk@...hat.com>
To:     Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org
Cc:     Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v2 1/4] KVM: x86: refactor req_immediate_exit logic

> On 9/24/23 14:44, Maxim Levitsky wrote:
> > +	if (vcpu->arch.req_immediate_exit)
> >   		kvm_make_request(KVM_REQ_EVENT, vcpu);
> > -		static_call(kvm_x86_request_immediate_exit)(vcpu);
> > -	}
> 
> Is it enough for your use case to add a new tracepoint here, instead of 
> adding req_immediate_exit to both entry and exit?


I prefer if possible to keep the req_immediate_exit field on entry only,
as it is pretty much an extension to the injected event data which I also
added to kvm_entry() tracepoint.

Best regards,
	Maxim Levitsky

> 
> Paolo
>