linux-kernel - Re: [PATCH 2/3] platform/x86: ISST: Allow level 0 to be not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <403141e7-461e-8b31-16f4-c2d6ee3d12a7@linux.intel.com>
Date:   Fri, 29 Sep 2023 15:16:49 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
cc:     Hans de Goede <hdegoede@...hat.com>, markgross@...nel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] platform/x86: ISST: Allow level 0 to be not
 present

On Mon, 25 Sep 2023, Srinivas Pandruvada wrote:

> It is possible that SST level 0 or base level is not present in some
> configurations. So don't set level 0 mask in level_en_mask by default.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> ---
>  drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> index 48465636aadb..e6d84ce0e7a5 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> @@ -372,9 +372,6 @@ static int sst_main(struct auxiliary_device *auxdev, struct tpmi_per_power_domai
>  	/* Read PP header */
>  	*((u64 *)&pd_info->pp_header) = readq(pd_info->sst_base + pd_info->sst_header.pp_offset);
>  
> -	/* Force level_en_mask level 0 */
> -	pd_info->pp_header.level_en_mask |= 0x01;
> -
>  	mask = 0x01;
>  	levels = 0;
>  	for (i = 0; i < 8; ++i) {
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>


-- 
 i.