linux-kernel - Re: [PATCH v2 1/5] dt-bindings: clock: qcom,camcc-common.yaml: Add a common file for camcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b6bf468-cb76-46fb-90be-85a2475cec0e@linaro.org>
Date:   Sat, 30 Sep 2023 16:14:46 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        andersson@...nel.org, agross@...nel.org, konrad.dybcio@...aro.org,
        mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        jonathan@...ek.ca, quic_tdas@...cinc.com,
        vladimir.zapolskiy@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: clock: qcom,camcc-common.yaml: Add a
 common file for camcc

On 30/09/2023 15:41, Bryan O'Donoghue wrote:
> Various of the camcc bindings are repeated serially. Aggregate the
> common defintions into one place declaring common required in one place
> also.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
>  .../bindings/clock/qcom,camcc-common.yaml     | 44 +++++++++++++++++++
>  .../bindings/clock/qcom,camcc-sm8250.yaml     | 32 ++------------
>  .../bindings/clock/qcom,sc7180-camcc.yaml     | 23 ++--------
>  .../bindings/clock/qcom,sc7280-camcc.yaml     | 23 ++--------
>  .../bindings/clock/qcom,sdm845-camcc.yaml     | 23 ++--------
>  .../bindings/clock/qcom,sm6350-camcc.yaml     | 13 ++----
>  .../bindings/clock/qcom,sm8450-camcc.yaml     | 33 ++------------
>  7 files changed, 67 insertions(+), 124 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml b/Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml
> new file mode 100644
> index 000000000000..ce0140985fe7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,camcc-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Camera Clock & Reset Controller common properties
> +
> +maintainers:
> +  - Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> +
> +description: |
> +  Qualcomm camera clock control module provides the clocks, resets and power
> +  domains on Qualcomm SoCs.
> +
> +allOf:
> +  - $ref: qcom,gcc.yaml#
> +
> +properties:
> +  compatible: true

Drop, not needed.

> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 4

No real benefit of these in common schema. It's still not precise :/

> +
> +  clock-names:
> +    minItems: 1
> +    maxItems: 4

The same.

> +
> +  power-domains:
> +    maxItems: 1
> +    description:
> +      A phandle and PM domain specifier for the MMCX power domain.

Not all bindings have it, so again not much benefits to have it in
common place.

> +
> +  required-opps:
> +    maxItems: 1
> +    description:
> +      OPP node describing required MMCX performance point.
> +
> +required:
> +  - compatible

Drop

> +  - clocks

As well... so this leads us to almost empty common binding. That's why I
suggested to use qcom,gcc.yaml.


Best regards,
Krzysztof