linux-kernel - Re: [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: Update gpio example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510d6407-8033-4f2e-aabf-bd3fb84875a9@linaro.org>
Date:   Sat, 30 Sep 2023 17:06:48 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Luca Weiss <luca.weiss@...rphone.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: Update gpio example

On 29/09/2023 10:17, Luca Weiss wrote:
> As per commit ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node
> label for PMIC gpios") all dts files now use the plural _gpios instead
> of the singular _gpio as label. Update the schema example also to match.
> 
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 55e931ba5b47..e4842e1fbd65 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -245,7 +245,7 @@ examples:
>              #address-cells = <1>;
>              #size-cells = <0>;
>  
> -            pmi8998_gpio: gpio@...0 {
> +            pmi8998_gpios: gpio@...0 

This does no make sense... you update label only here, but not in any
user of it which proves that label is not used. If it is not used, it
should be dropped, not changed...

Best regards,
Krzysztof