[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <924f8334-f4d3-4c41-b8c2-08f1a15c7fa0@linaro.org>
Date: Sat, 30 Sep 2023 17:52:18 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jisheng Zhang <jszhang@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Cc: linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Guo Ren <guoren@...nel.org>,
Fu Wei <wefu@...hat.com>, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add T-HEAD TH1520 USB controller
On 28/09/2023 07:21, Krzysztof Kozlowski wrote:
> Drop stray blank line
>
>> + usb {
>> + compatible = "thead,th1520-usb";
>
> Use 4 spaces for example indentation.
>
>> + reg = <0xec03f000 0x1000>;
>> + clocks = <&clk 1>,
>> + <&clk 2>,
>> + <&clk 3>,
>> + <&clk 4>;
>> + clock-names = "ref", "bus_early", "phy", "suspend";
>> + ranges;
>
> Are you sure you do not have W=1 warnings in DTS?
Ah, as we can see from bot's report, you have warnings. Please test your
DTS with dtbs_check W=1 and fix all (*ALL*) warnings.
This looks like missing proper addresses in the ranges.
Best regards,
Krzysztof
Powered by blists - more mailing lists