linux-kernel - Re: arch/powerpc/kernel/traps.c:1167:19: error: unused function '__parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ac0620e-2c8e-4030-ed4a-63527873b41a@csgroup.eu>
Date:   Sat, 30 Sep 2023 15:57:14 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     kernel test robot <lkp@...el.com>
CC:     "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        "oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: arch/powerpc/kernel/traps.c:1167:19: error: unused function
 '__parse_fpscr'



Le 30/09/2023 à 15:40, kernel test robot a écrit :
> Hi Christophe,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   9f3ebbef746f89f860a90ced99a359202ea86fde
> commit: ca13c130a43fe3ab625d22ada0a61e5c0b612229 powerpc/4xx: Remove WatchdogHandler() to fix no previous prototype error
> date:   6 weeks ago
> config: powerpc-kilauea_defconfig (https://download.01.org/0day-ci/archive/20230930/202309302131.bsuutuxs-lkp@intel.com/config)
> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230930/202309302131.bsuutuxs-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202309302131.bsuutuxs-lkp@intel.com/
> 

This problem is fixes by patch 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/5de2998c57f3983563b27b39228ea9a7229d4110.1695385984.git.christophe.leroy@csgroup.eu/

And it is not related to the above mentioned commit, see fixes tag in 
the patch.


> All errors (new ones prefixed by >>):
> 
>>> arch/powerpc/kernel/traps.c:1167:19: error: unused function '__parse_fpscr' [-Werror,-Wunused-function]
>      1167 | static inline int __parse_fpscr(unsigned long fpscr)
>           |                   ^
>     1 error generated.
> 
> 
> vim +/__parse_fpscr +1167 arch/powerpc/kernel/traps.c
> 
> 14cf11af6cf608 Paul Mackerras    2005-09-26  1166
> 5fad293bcbd48d Kumar Gala        2007-02-07 @1167  static inline int __parse_fpscr(unsigned long fpscr)
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1168  {
> aeb1c0f6ff18f5 Eric W. Biederman 2018-04-17  1169  	int ret = FPE_FLTUNK;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1170
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1171  	/* Invalid operation */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1172  	if ((fpscr & FPSCR_VE) && (fpscr & FPSCR_VX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1173  		ret = FPE_FLTINV;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1174
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1175  	/* Overflow */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1176  	else if ((fpscr & FPSCR_OE) && (fpscr & FPSCR_OX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1177  		ret = FPE_FLTOVF;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1178
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1179  	/* Underflow */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1180  	else if ((fpscr & FPSCR_UE) && (fpscr & FPSCR_UX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1181  		ret = FPE_FLTUND;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1182
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1183  	/* Divide by zero */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1184  	else if ((fpscr & FPSCR_ZE) && (fpscr & FPSCR_ZX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1185  		ret = FPE_FLTDIV;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1186
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1187  	/* Inexact result */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1188  	else if ((fpscr & FPSCR_XE) && (fpscr & FPSCR_XX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1189  		ret = FPE_FLTRES;
> 5fad293bcbd48d Kumar Gala        2007-02-07  1190
> 5fad293bcbd48d Kumar Gala        2007-02-07  1191  	return ret;
> 5fad293bcbd48d Kumar Gala        2007-02-07  1192  }
> 5fad293bcbd48d Kumar Gala        2007-02-07  1193
> 
> :::::: The code at line 1167 was first introduced by commit
> :::::: 5fad293bcbd48d9a2370020cf60e4b4a42559b12 [POWERPC] Fixup error handling when emulating a floating point instruction
> 
> :::::: TO: Kumar Gala <galak@...nel.crashing.org>
> :::::: CC: Kumar Gala <galak@...nel.crashing.org>
>