[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2720c275-9fc8-426f-b72d-56a06afec6fe@linaro.org>
Date: Sat, 30 Sep 2023 17:54:51 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tomer Maimon <tmaimon77@...il.com>, peter.chen@...nel.org,
gregkh@...uxfoundation.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, xu.yang_2@....com,
peng.fan@....com, avifishman70@...il.com, tali.perry1@...il.com,
joel@....id.au, venture@...gle.com, yuenn@...gle.com,
benjaminfair@...gle.com, j.neuschaefer@....net
Cc: openbmc@...ts.ozlabs.org, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 3/3] usb: chipidea: Add support for NPCM
On 27/09/2023 11:55, Tomer Maimon wrote:
> Add Nuvoton NPCM BMC SoCs support to USB ChipIdea driver.
> NPCM SoC include ChipIdea IP block that used for USB device controller
> mode.
...
> + ci = devm_kzalloc(&pdev->dev, sizeof(*ci), GFP_KERNEL);
> + if (!ci)
> + return -ENOMEM;
> + platform_set_drvdata(pdev, ci);
> +
> + ci->core_clk = devm_clk_get_optional(dev, NULL);
> + if (IS_ERR(ci->core_clk))
> + return PTR_ERR(ci->core_clk);
> +
> + ret = clk_prepare_enable(ci->core_clk);
> + if (ret) {
> + dev_err(dev, "failed to enable the clock: %d\n", ret);
> + return ret;
return dev_err_probe()
...
> +
> +module_platform_driver(npcm_udc_driver);
> +
> +MODULE_DESCRIPTION("NPCM USB device controller driver");
> +MODULE_AUTHOR("Tomer Maimon <tomer.maimon@...oton.com>");
> +MODULE_ALIAS("platform:npcm-udc");
Nope... if you need it, your tables are wrong.
Best regards,
Krzysztof
Powered by blists - more mailing lists