linux-kernel - Re: [PATCH 1/2] rust: add Soft-RoCE driver basic structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Sep 2023 13:47:00 -0400
From:   Trevor Gross <tmgross@...ch.edu>
To:     AllenX <xubo3006@....com>
Cc:     rust-for-linux@...r.kernel.org, ojeda@...nel.org,
        alex.gaynor@...il.com, wedsonaf@...il.com, boqun.feng@...il.com,
        gary@...yguo.net, bjorn3_gh@...tonmail.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] rust: add Soft-RoCE driver basic structure

On Sat, Sep 30, 2023 at 12:32 PM AllenX <xubo3006@....com> wrote:
>
> add soft-Roce rxe device net driver basic structure and Rust security abstration interface

It looks like your patch hit the list twice, see [1] and [2]. Also,
the body should be hard wrapped [3].

Since it's usually the first thing to be asked, do you have a
real-world driver that this is intended for? Typically new
abstractions don't get merged upstream unless there is an in-tree use
case.

We can still give the patch a cursory review from the Rust side even
if it isn't meant for upstreaming as-is. For future reference, you can
have "RFC PATCH" in the subject to make this clear (`git format-patch
--rfc` does this)

[1]: https://lore.kernel.org/rust-for-linux/20230930163256.60779-1-xubo3006@163.com/
[2]: https://lore.kernel.org/rust-for-linux/20230930161443.58812-1-xubo3006@163.com/
[3]: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format