linux-kernel - Re: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+fCnZe809yDRNQ_sQHenOE8idBDLDk_p=PG1-_O2NK7bMVxwQ@mail.gmail.com>
Date:   Sun, 1 Oct 2023 08:58:55 +0200
From:   Andrey Konovalov <andreyknvl@...il.com>
To:     Joey Jiao <quic_jiangenj@...cinc.com>
Cc:     Alexander Potapenko <glider@...gle.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        kasan-dev@...glegroups.com, quic_likaid@...cinc.com,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST_ONLY mode

On Sat, Sep 30, 2023 at 12:13 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> On Fri, Sep 29, 2023 at 11:06 PM Alexander Potapenko <glider@...gle.com> wrote:
> >
> > (CC Masahiro Yamada)
> >
> > On Thu, Sep 28, 2023 at 6:16 AM Joey Jiao <quic_jiangenj@...cinc.com> wrote:
> > >
> > > Fow low memory device, full enabled kasan just not work.
> > > Set KASAN_SANITIZE to n when CONFIG_KASAN_WHITELIST_ONLY=y.
> > > So we can enable kasan for single file or module.
> >
> > I don't have technical objections here, but it bothers me a bit that
> > we are adding support for KASAN_SANITIZE:=y, although nobody will be
> > adding KASAN_SANITIZE:=y to upstream Makefiles - only development
> > kernels when debugging on low-end devices.
> >
> > Masahiro, is this something worth having in upstream Kconfig code?
>
>
> Even if we apply this patch to the upstream,
> you will end up with adding 'KASAN_SANITIZE :=y'
> to the single file/Makefile.
>
> I am not convinced with this patch
> since this nod is not so useful standalone.

Yeah, I agree here, I don't think this change belongs as is in the
upstream KASAN code.