linux-kernel - RE: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11e5eafbf8ac42fd90491e09e96d8eea@quicinc.com>
Date:   Mon, 9 Oct 2023 01:14:31 +0000
From:   "Joey Jiao (QUIC)" <quic_jiangenj@...cinc.com>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        Alexander Potapenko <glider@...gle.com>
CC:     "kasan-dev@...glegroups.com" <kasan-dev@...glegroups.com>,
        "Kevin Ding (QUIC)" <quic_likaid@...cinc.com>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        "Nicolas Schier" <nicolas@...sle.eu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        "Changmin Liu (QUIC)" <quic_changmil@...cinc.com>
Subject: RE: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST_ONLY mode

Right, it will be only useful for low memory kernel where 'KASAN_SANITIZE :=y' has to be added explicitly in local as hotfix.

-----Original Message-----
From: Masahiro Yamada <masahiroy@...nel.org> 
Sent: Saturday, September 30, 2023 6:12 PM
To: Alexander Potapenko <glider@...gle.com>
Cc: Joey Jiao (QUIC) <quic_jiangenj@...cinc.com>; kasan-dev@...glegroups.com; Kevin Ding (QUIC) <quic_likaid@...cinc.com>; Andrey Ryabinin <ryabinin.a.a@...il.com>; Andrey Konovalov <andreyknvl@...il.com>; Dmitry Vyukov <dvyukov@...gle.com>; Vincenzo Frascino <vincenzo.frascino@....com>; Nathan Chancellor <nathan@...nel.org>; Nick Desaulniers <ndesaulniers@...gle.com>; Nicolas Schier <nicolas@...sle.eu>; linux-kernel@...r.kernel.org; linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST_ONLY mode

On Fri, Sep 29, 2023 at 11:06 PM Alexander Potapenko <glider@...gle.com> wrote:
>
> (CC Masahiro Yamada)
>
> On Thu, Sep 28, 2023 at 6:16 AM Joey Jiao <quic_jiangenj@...cinc.com> wrote:
> >
> > Fow low memory device, full enabled kasan just not work.
> > Set KASAN_SANITIZE to n when CONFIG_KASAN_WHITELIST_ONLY=y.
> > So we can enable kasan for single file or module.
>
> I don't have technical objections here, but it bothers me a bit that 
> we are adding support for KASAN_SANITIZE:=y, although nobody will be 
> adding KASAN_SANITIZE:=y to upstream Makefiles - only development 
> kernels when debugging on low-end devices.
>
> Masahiro, is this something worth having in upstream Kconfig code?


Even if we apply this patch to the upstream, you will end up with adding 'KASAN_SANITIZE :=y'
to the single file/Makefile.

I am not convinced with this patch
since this nod is not so useful standalone.



> > Signed-off-by: Joey Jiao <quic_jiangenj@...cinc.com>
> Reviewed-by: Alexander Potapenko <glider@...gle.com>



--
Best Regards
Masahiro Yamada