linux-kernel - RE: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device' error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Oct 2023 06:57:32 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     André Apitzsch <git@...tzsch.eu>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device' error

Hi André Apitzsch,

> Subject: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device' error
> 
> Explicity specify array indices to fix mapping between
> asahi_compass_chipset and ak_def_array.
> While at it, remove unneeded AKXXXX.
> 
> Fixes: 4f9ea93afde1 ("iio: magnetometer: ak8975: Convert enum->pointer for
> data in the match tables")
> Signed-off-by: André Apitzsch <git@...tzsch.eu>
> ---
>  drivers/iio/magnetometer/ak8975.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/ak8975.c
> b/drivers/iio/magnetometer/ak8975.c
> index 8cfceb007936..dd466c5fa621 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -204,7 +204,6 @@ static long ak09912_raw_to_gauss(u16 data)
> 
>  /* Compatible Asahi Kasei Compass parts */  enum asahi_compass_chipset {
> -	AKXXXX		= 0,

I guess this change is enough, after this AK8975 = 0 and
No need to update the mapping. Anyway this is personal preference.

Looks good to me.

Reviewed-by: Biju Das <biju.das.jz@...renesas.com>

Cheers,
Biju

>  	AK8975,
>  	AK8963,
>  	AK09911,
> @@ -248,7 +247,7 @@ struct ak_def {
>  };
> 
>  static const struct ak_def ak_def_array[] = {
> -	{
> +	[AK8975] = {
>  		.type = AK8975,
>  		.raw_to_gauss = ak8975_raw_to_gauss,
>  		.range = 4096,
> @@ -273,7 +272,7 @@ static const struct ak_def ak_def_array[] = {
>  			AK8975_REG_HYL,
>  			AK8975_REG_HZL},
>  	},
> -	{
> +	[AK8963] = {
>  		.type = AK8963,
>  		.raw_to_gauss = ak8963_09911_raw_to_gauss,
>  		.range = 8190,
> @@ -298,7 +297,7 @@ static const struct ak_def ak_def_array[] = {
>  			AK8975_REG_HYL,
>  			AK8975_REG_HZL},
>  	},
> -	{
> +	[AK09911] = {
>  		.type = AK09911,
>  		.raw_to_gauss = ak8963_09911_raw_to_gauss,
>  		.range = 8192,
> @@ -323,7 +322,7 @@ static const struct ak_def ak_def_array[] = {
>  			AK09912_REG_HYL,
>  			AK09912_REG_HZL},
>  	},
> -	{
> +	[AK09912] = {
>  		.type = AK09912,
>  		.raw_to_gauss = ak09912_raw_to_gauss,
>  		.range = 32752,
> @@ -348,7 +347,7 @@ static const struct ak_def ak_def_array[] = {
>  			AK09912_REG_HYL,
>  			AK09912_REG_HZL},
>  	},
> -	{
> +	[AK09916] = {
>  		.type = AK09916,
>  		.raw_to_gauss = ak09912_raw_to_gauss,
>  		.range = 32752,
> 
> ---
> base-commit: df964ce9ef9fea10cf131bf6bad8658fde7956f6
> change-id: 20231001-ak_magnetometer-b063098082dd
> 
> Best regards,
> --
> André Apitzsch <git@...tzsch.eu>